Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correctly generate invitation URLs for peer DIDs in /connections… #1510

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

MonolithicMonk
Copy link

…/{conn_id}/invitation endpoint fix to retrieve invitation urls for did:peer. See issue.

@MonolithicMonk MonolithicMonk force-pushed the fix-peer-did-invitation-url branch from cde2d67 to ebefaa6 Compare February 20, 2025 21:06
…/{conn_id}/invitation endpoint

Signed-off-by: Yuki I <[email protected]>
Copy link
Contributor

@loneil loneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, can still fetch invitation with OOB invites and connections invitations (though those are deprecating), and also with did:peer2/4 after these changes.

@loneil loneil merged commit a50e9ec into bcgov:main Feb 21, 2025
4 of 7 checks passed
@MonolithicMonk MonolithicMonk deleted the fix-peer-did-invitation-url branch February 22, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants