Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main): update github actions node version #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

StanHannebelle
Copy link

@StanHannebelle StanHannebelle commented Oct 27, 2022

This updates node version to 16 and upgrades versions of actions/checkout and actions/setup-node

Should resolve #35

@StanHannebelle StanHannebelle force-pushed the update_github_actions_node_version branch from 70b3263 to d011955 Compare October 27, 2022 16:39
@StanHannebelle
Copy link
Author

@bcoe Could you please have a look at this PR?

@chrisjohnson00
Copy link

Can confirm this works!

@danielloader
Copy link

It's been so long you'll need to bump this again to Node 20.

@danielloader
Copy link

danielloader commented Jun 3, 2024

@StanHannebelle how do you feel about hosting a fork with this PR merged in for Node 20 so we can get on with our lives without the deprecation warnings?

@chrisjohnson00
Copy link

@StanHannebelle how do you feel about hosting a fork with this PR merged in for Node 20 so we can get on with our lives without the deprecation warnings?

My work uses this action, and we have a "private fork" (clone not fork) for this. I'd suggest you do something similar. FWIW: I've a PR open in Stan's fork for over a year without any comment/feedback, so it isn't looking like he's interested or using this anymore.

I'll also note that you can replace this action with actions/github-script but it isn't as user friendly:

      - name: Add Breaking Label
        if: steps.check-breaking.outputs.is-breaking-change == 'true'
        uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea  # v7.0.1, 2023-11-17
        with:
          # context.issue.number will return either an issue number or a PR number:
          # https://github.com/actions/toolkit/blob/92695f58daf7b460a9ae2a4682d8e65a5dea7bc8/packages/github/src/context.ts#L60
          script: |
            github.rest.issues.addLabels({
              issue_number: context.issue.number,
              owner: context.repo.owner,
              repo: context.repo.repo,
              labels: ['breaking']
            });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node16
3 participants