Added support for cache keys that are not hashed via config option READABLE_CACHE_KEYS#674
Added support for cache keys that are not hashed via config option READABLE_CACHE_KEYS#674rdiaztushman wants to merge 1 commit intobcosca:devfrom
Conversation
READABLE_CACHE_KEYS fixes bcosca#672
|
A few things:
|
|
I was deliberately trying to 1) minimize the number of changes and 2) preserve current behavior. That's why I didn't add the key to the hive (which means I needed to use empty). There is no change in F3's behavior unless you add READABLE_CACHE_KEYS to your config with a value of true or 1. |
Leaving an undocumented variable check in an open source framework isn't the way. When someone browses the source they'd be met with a non-existent key and probably left scratching their heads (as I was when I viewed your commit). By adding the key to hive, the behaviour stays identical and leaves behind a nicer trail to follow. I agree with this toggle to switch hash on/off, as I've implemented it in userland code a few times before via |


fixes #672