Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use secure gRPC channels for spot_wrapper.testing mocks #103

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

mhidalgo-bdai
Copy link
Collaborator

Pretty much what the title says. This patch drops bosdyn monkeypatching in favor of self-signed SSL certificates to allow for secure gRPC channels during spot_wrapper.testing driven tests.

@coveralls
Copy link

coveralls commented Apr 12, 2024

Pull Request Test Coverage Report for Build 8667795090

Details

  • 34 of 34 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 96.227%

Totals Coverage Status
Change from base Build 8482738848: 0.03%
Covered Lines: 1913
Relevant Lines: 1988

💛 - Coveralls

Signed-off-by: Michel Hidalgo <[email protected]>
@mhidalgo-bdai
Copy link
Collaborator Author

I will hold this off until I have a matching PR for https://github.com/bdaiinstitute/spot_ros2 (in the works).

@mhidalgo-bdai
Copy link
Collaborator Author

mhidalgo-bdai commented Apr 12, 2024

FTR these certificates and keys are dummy ones. I don't know if we have a policy w.r.t. these nonetheless.

Signed-off-by: Michel Hidalgo <[email protected]>
Copy link
Collaborator

@bhung-bdai bhung-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Out of curiosity, does this represent the actual method that is used by Spot during authentication or is it just the next best thing?

@mhidalgo-bdai
Copy link
Collaborator Author

mhidalgo-bdai commented Apr 16, 2024

does this represent the actual method that is used by Spot during authentication

This allows us to use the Spot SDK as-is, so if it's not exactly equivalent to what the real robot does, I'd imagine it gets quite close.

@mhidalgo-bdai
Copy link
Collaborator Author

Testing went well here and in bdaiinstitute/spot_ros2#347. Merging!

@mhidalgo-bdai mhidalgo-bdai merged commit a630665 into main Apr 18, 2024
6 checks passed
@mhidalgo-bdai mhidalgo-bdai deleted the mhidalgo-bdai/secure-grpc-for-tests branch April 18, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants