-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use secure gRPC channels for spot_wrapper.testing
mocks
#103
Conversation
Signed-off-by: Michel Hidalgo <[email protected]>
Pull Request Test Coverage Report for Build 8667795090Details
💛 - Coveralls |
Signed-off-by: Michel Hidalgo <[email protected]>
I will hold this off until I have a matching PR for https://github.com/bdaiinstitute/spot_ros2 (in the works). |
FTR these certificates and keys are dummy ones. I don't know if we have a policy w.r.t. these nonetheless. |
Signed-off-by: Michel Hidalgo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Out of curiosity, does this represent the actual method that is used by Spot during authentication or is it just the next best thing?
This allows us to use the Spot SDK as-is, so if it's not exactly equivalent to what the real robot does, I'd imagine it gets quite close. |
Testing went well here and in bdaiinstitute/spot_ros2#347. Merging! |
Pretty much what the title says. This patch drops
bosdyn
monkeypatching in favor of self-signed SSL certificates to allow for secure gRPC channels duringspot_wrapper.testing
driven tests.