Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dataset loading and handeye cal #150

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

glvov-bdai
Copy link
Collaborator

Was using my hand-eye cal util for another application (with Franka arms) and discovered a few small issues that could easily be resolved. Tested on new data and old spot data

  • Generalized loading of data to not depend on image size (inadvertently did previously)
  • Added extra checks in hand-eye cal determination

@glvov-bdai glvov-bdai force-pushed the fix/dataset_load_and_hand_eye branch from 2dfc914 to 64f44d0 Compare November 15, 2024 01:01
@coveralls
Copy link

coveralls commented Nov 15, 2024

Pull Request Test Coverage Report for Build 11849193353

Details

  • 0 of 56 (0.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 40.626%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spot_wrapper/calibration/calibration_util.py 0 56 0.0%
Files with Coverage Reduction New Missed Lines %
spot_wrapper/calibration/calibration_util.py 5 0.0%
Totals Coverage Status
Change from base Build 11486927459: -0.2%
Covered Lines: 1870
Relevant Lines: 4603

💛 - Coveralls

Copy link
Collaborator

@tcappellari-bdai tcappellari-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - good catch

@tcappellari-bdai tcappellari-bdai merged commit c78ebfb into main Nov 15, 2024
3 checks passed
@tcappellari-bdai tcappellari-bdai deleted the fix/dataset_load_and_hand_eye branch November 15, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants