extending the epochal discrete CTMC model#1135
Open
jsigao wants to merge 3 commits intobeast-dev:hmc-clockfrom
Open
extending the epochal discrete CTMC model#1135jsigao wants to merge 3 commits intobeast-dev:hmc-clockfrom
jsigao wants to merge 3 commits intobeast-dev:hmc-clockfrom
Conversation
…long a branch when that branch overlaps with both multiple epochal matrices and multiple epochal rates
…istories under either an epochal matrix model or an epochal rate model (or both)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is modified from a previous PR following @msuchard's suggestion. One of the commits (commit
859f33f) contained in this pull request has been fully revised to remove the unnecessary code duplication caused by the (trivial version of)getBranchRateModelMappingfunction copied across all thebranchratemodelclasses (now the trivial version of this function is implemented in the AbstractBranchRateModel class so this function has been removed from all the branchRate classes extending the abstract class). (The other two commits in this PR remain unchanged.)I have done an additional experiment to validate the implementation extension contained in this pull request. Please see this synopsis.pdf document for a brief summary of the experiment. (The supplementary files that I used to perform this experiment is available in this Qmu_bothvary_test.zip folder).
Please let me know if there is anything unclear or missing in the experiment. I have also changed the target branch of this pull request to
hmc-clockas advised. Thanks again for reviewing this PR.For the sake of completeness, the PR message from the previous PR is included below.