Modularize canonical OU machinery#1253
Open
fil-monti wants to merge 118 commits into
Open
Conversation
CanonicalSelectionMatrixGradientFormula: - Change nativeRotationGradientScratch from double[][] to double[] flat, matching OrthogonalBlockCanonicalParameterization.accumulateNativeGradient FromCanonicalContributionFlat new flat signature. - Add nativeRotationGradient2D scratch for OrthogonalMatrixProvider.pullBack Gradient calls that still require double[][]. - Copy flat → 2D via GaussianMatrixOps.copyFlatToMatrix before assembly. - Replace zero(double[][]) with Arrays.fill. All 111 tests pass (ant junit-canonical-behavior). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Compute shared covariance adjoints once per branch for selection and diffusion gradients. Delay stationary-mean gradient rotation by accumulating branch contributions in D-basis and rotating once at finish. Tests: ant compile-all; ant junit-canonical-behavior
Replace dense EJML multiplies involving block-diagonal expD in the orthogonal covariance pullback with block-aware kernels. Tests: ant compile-all; ant junit-canonical-behavior
Split parameter updates from time evaluations and add a specialized 2x2 equal-diagonal coefficient path with instrumentation and tests. Register GeneralOUTraitSimulator in parser lists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.