Skip to content

194 graceful fail#203

Open
greenw0lf wants to merge 4 commits intomainfrom
194-graceful-fail
Open

194 graceful fail#203
greenw0lf wants to merge 4 commits intomainfrom
194-graceful-fail

Conversation

@greenw0lf
Copy link
Contributor

If either one of you @Veldhoen or @gb-beng can have a look at this, that'd be great!

Closes #194

The shutdown event blocks all incoming requests, therefore we cannot wait for a get request for the current task to be received first before shutting down the app. So, the alternative for now is to at least let the current task finish, then program something in the Airflow triggerer that checks in S3 whether a specific program has been transcribed already or not.
@greenw0lf greenw0lf requested review from Veldhoen and gb-beng January 23, 2025 10:36
@greenw0lf greenw0lf self-assigned this Jan 23, 2025
@Veldhoen
Copy link
Contributor

How would you suggest to test this?

@greenw0lf greenw0lf removed the request for review from gb-beng January 28, 2025 10:16
@greenw0lf
Copy link
Contributor Author

  1. Set up the worker locally
  2. Run the local instance via scripts/run.sh (or run-api.sh)
  3. Go to http://localhost:5333/docs and send a POST request to the worker. I used an S3 URI that would keep the worker going for longer, check DMs on Slack
  4. Ctrl+C in the terminal where the worker is running

It is expected that the worker will stay alive until the process is done, then shut down completely. Unfortunately, it doesn't work via Docker, but Govert recommended that I test locally anyway

Base automatically changed from improve-transcript-logging to main April 24, 2025 09:26
@Veldhoen Veldhoen removed their request for review September 5, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants