Glue sql bug fix#4
Merged
Merged
Conversation
prevents linting errors related to closing parentheses in sql strings. which were false positives.
- Fix backward quote search mistaking closing quotes for opening quotes - Add position validation to prevent cross-function SQL detection - Trim leading whitespace from multi-line SQL background highlighting - Extract regex patterns and magic numbers to named constants - Extract theme colors to class constants with accurate descriptions Resolves issue where commenting/uncommenting code after SQL strings caused false positive "unmatched parentheses" errors.
Collaborator
Author
|
resolves false positive linting error when using Also improves code background highlighting to remove leading white space and is configurable on its own, alongside semantic highlighting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.