fix: disable cmake.default and passive_targets in cookiecutter tidy config#416
Merged
neatudarius merged 1 commit intoJul 15, 2026
Merged
Conversation
|
coverage: 100.0%. remained the same — neatudarius:fix/exemplar-beman-tidy-checks into bemanproject:main |
ednolan
requested changes
Jul 15, 2026
ednolan
left a comment
ednolan
left a comment
Member
There was a problem hiding this comment.
This breaks module support (as picked up by CI). We need to think about this more.
neatudarius
force-pushed
the
fix/exemplar-beman-tidy-checks
branch
from
July 15, 2026 20:05
cff7002 to
b6542ea
Compare
Member
Author
Agree. It's just an experimental change. It's OK that you blocked it, but I wasn't going to put this to review (anyways, not merge without discussion). I propose just to keep the checks disabled inside cookiecutter. And we'll discuss next week more. @ednolan , it is OK this way? |
neatudarius
force-pushed
the
fix/exemplar-beman-tidy-checks
branch
from
July 15, 2026 20:06
b6542ea to
1ab2c9c
Compare
neatudarius
changed the title
neatudarius
marked this pull request as ready for review
July 15, 2026 20:07
neatudarius
requested review from
bretbrownjr,
camio,
dietmarkuehl,
steve-downey and
wusatosi
as code owners
July 15, 2026 20:07
Document why each disabled_rules entry is temporarily off in the cookiecutter template and in exemplar's own .beman-tidy.yaml. No CMake changes.
neatudarius
force-pushed
the
fix/exemplar-beman-tidy-checks
branch
from
July 15, 2026 20:09
1ab2c9c to
bba240f
Compare
neatudarius
changed the title
Member
|
Sounds good |
Member
Author
|
I'm doing admin merge since Eddie also gave the like. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks
Run on beman.exemplarfor beman-tidy PRs implementingcmake.defaultandcmake.passive_targets.Temporarily disables both checks in the cookiecutter
.beman-tidy.yamlfor stamped libraries. Each disabled rule has a TODO explaining why. No CMake changes — module support stays intact.Test plan
beman-tidy --require-allpassesrun-on-exemplarCI green after merge