Skip to content

fix: stuck on exit #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion VRCFaceTracking.Core/Library/UnifiedLibManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,12 @@ private bool TeardownModule(ModuleRuntimeInfo module)
{
// Edge case, we wait for the thread to finish before unloading the assembly
_logger.LogDebug("Waiting for {module}'s thread to join...", module.Module.GetType().Name);
module.UpdateThread.Join();
// Specify a timeout in milliseconds
var timeoutMilliseconds = 1000;
if (!module.UpdateThread.Join(timeoutMilliseconds))
{
_logger.LogWarning("{module}'s thread did not finish within the timeout period.", module.Module.GetType().Name);
}
}

module.Module.Teardown();
Expand Down