Merge pull request AY2324S2-CS2103T-F12-2#264 from bennyLCK/branch-b-…

…CodeQuality Delete all commented out codes
bennyLCK · Apr 15, 2024 · 2c56b7a · 2c56b7a
2 parents a7efa35 + b2eb108
commit 2c56b7a
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 37 deletions.
diff --git a/docs/DeveloperGuide.md b/docs/DeveloperGuide.md
@@ -121,7 +121,7 @@ How the parsing works:
 ### Model component
 **API** : [`Model.java`](https://github.com/se-edu/addressbook-level3/tree/master/src/main/java/seedu/address/model/Model.java)
 
-<puml src="diagrams/ModelClassDiagram.puml" width="800" />
+<puml src="diagrams/ModelClassDiagram.puml" width="1500" height="1000" />
 
 
 The `Model` component,

diff --git a/docs/diagrams/ModelClassDiagram.puml b/docs/diagrams/ModelClassDiagram.puml
@@ -3,7 +3,6 @@
 skinparam arrowThickness 1.1
 skinparam arrowColor MODEL_COLOR
 skinparam classBackgroundColor MODEL_COLOR
-scale 10
 
 
 Package Model as ModelPackage <<Rectangle>>{

diff --git a/src/main/java/seedu/address/model/article/UniqueArticleList.java b/src/main/java/seedu/address/model/article/UniqueArticleList.java
@@ -35,14 +35,6 @@ public boolean contains(Article toCheck) {
      */
     public void add(Article toAdd) {
         requireNonNull(toAdd);
-
-        /*
-        if (contains(toAdd)) {
-            throw new DuplicatePersonException();
-        }
-
-         */
-
         internalList.add(toAdd);
     }
 
@@ -55,16 +47,6 @@ public void setArticle(Article target, Article editedArticle) {
 
         int index = internalList.indexOf(target);
 
-        /*
-        if (index == -1) {
-            throw new PersonNotFoundException();
-        }
-
-        if (!target.isSameArticle(editedArticle) && contains(editedArticle)) {
-            throw new DuplicatePersonException();
-        }
-        */
-
         internalList.set(index, editedArticle);
     }
 
@@ -74,12 +56,6 @@ public void setArticle(Article target, Article editedArticle) {
     public void remove(Article toRemove) {
         requireNonNull(toRemove);
         internalList.remove(toRemove);
-
-        /*
-        if (!internalList.remove(toRemove)) {
-            throw new PersonNotFoundException();
-        }
-        */
     }
 
     public void setArticles(UniqueArticleList replacement) {
@@ -93,13 +69,6 @@ public void setArticles(UniqueArticleList replacement) {
      */
     public void setArticles(List<Article> articles) {
         requireAllNonNull(articles);
-
-        /*
-        if (!personsAreUnique(persons)) {
-            throw new DuplicatePersonException();
-        }
-        */
-
         internalList.setAll(articles);
     }
 

diff --git a/src/main/java/seedu/address/model/person/NameWithinArticlePredicate.java b/src/main/java/seedu/address/model/person/NameWithinArticlePredicate.java
@@ -22,10 +22,6 @@ public NameWithinArticlePredicate(Article article) {
 
     @Override
     public boolean test(Person person) {
-        /*return article.getAuthors().stream()
-                .anyMatch(author -> person.getName().fullName.equals(author.authorName)) ||
-                article.getSources().stream()
-                .anyMatch(source -> person.getName().fullName.equals(source.sourceName));*/
         return article.getPersons().contains(person);
     }