Skip to content

Conversation

@foosinn
Copy link

@foosinn foosinn commented Jan 8, 2021

This provides a Docker image for bepasty.

Goals:

  • run as unprivileged user
  • no write access to config
  • tries to be simple
  • basic configuration via environment variables
  • extended configuration via file mount

I'm not entirely sure if a Docker image is wanted. Neither found one in the repository nor the issues.

@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #262 (528c9bf) into master (f4f8d97) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   71.38%   71.38%           
=======================================
  Files          44       44           
  Lines        2558     2558           
=======================================
  Hits         1826     1826           
  Misses        732      732           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4f8d97...528c9bf. Read the comment docs.

@foosinn foosinn force-pushed the docker branch 4 times, most recently from 89712b5 to 528c9bf Compare January 8, 2021 22:48
@ThomasWaldmann
Copy link
Contributor

can somebody who is familiar with docker please review this?

@duchenpaul
Copy link

This is nice, please merge this PR

@ThomasWaldmann
Copy link
Contributor

@duchenpaul so you practically tried it?

Copy link
Contributor

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had a quick look, some feedback/questions.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.33%. Comparing base (f4f8d97) to head (14a165e).
⚠️ Report is 124 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   71.38%   70.33%   -1.05%     
==========================================
  Files          44       44              
  Lines        2558     2623      +65     
==========================================
+ Hits         1826     1845      +19     
- Misses        732      778      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ilosariph
Copy link

A docker image would bi amazing, is there any plan for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants