-
Notifications
You must be signed in to change notification settings - Fork 47
Docker Image #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Docker Image #262
Conversation
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
=======================================
Coverage 71.38% 71.38%
=======================================
Files 44 44
Lines 2558 2558
=======================================
Hits 1826 1826
Misses 732 732 Continue to review full report at Codecov.
|
89712b5 to
528c9bf
Compare
|
can somebody who is familiar with docker please review this? |
|
This is nice, please merge this PR |
|
@duchenpaul so you practically tried it? |
ThomasWaldmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had a quick look, some feedback/questions.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #262 +/- ##
==========================================
- Coverage 71.38% 70.33% -1.05%
==========================================
Files 44 44
Lines 2558 2623 +65
==========================================
+ Hits 1826 1845 +19
- Misses 732 778 +46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
A docker image would bi amazing, is there any plan for this? |
This provides a Docker image for bepasty.
Goals:
I'm not entirely sure if a Docker image is wanted. Neither found one in the repository nor the issues.