Fixing lot of warnings and info's

mostly turning warnings off

Author: jantje

io.sloeber.core/src/cc/arduino/packages/ssh/NoInteractionUserInfo.java

@@ -31,7 +31,7 @@
 
 import com.jcraft.jsch.UserInfo;
 
-@SuppressWarnings({ "unqualified-field-access" })
+//@SuppressWarnings({ "unqualified-field-access" })
 public class NoInteractionUserInfo implements UserInfo {
 
 	private final String password;

io.sloeber.core/src/cc/arduino/packages/ssh/SCP.java

@@ -39,7 +39,7 @@
 import com.jcraft.jsch.ChannelExec;
 import com.jcraft.jsch.Session;
 
-@SuppressWarnings({ "unused", "nls", "unqualified-field-access" })
+@SuppressWarnings({ "unused", "nls" })
 public class SCP extends SSH {
 
 	private Channel channel;

io.sloeber.core/src/cc/arduino/packages/ssh/SSH.java

@@ -39,7 +39,7 @@
 import com.jcraft.jsch.JSchException;
 import com.jcraft.jsch.Session;
 
-@SuppressWarnings({ "nls", "unqualified-field-access" })
+@SuppressWarnings({ "nls","unused" })
 public class SSH {
 
 	final Session session;

io.sloeber.core/src/cc/arduino/packages/ssh/SSHConfigFileSetup.java

@@ -40,7 +40,7 @@
 
 import cc.arduino.packages.BoardPort;
 
-@SuppressWarnings({ "nls", "unqualified-field-access" })
+@SuppressWarnings({ "nls" })
 public class SSHConfigFileSetup implements SSHClientSetupChainRing {
 
 	private final SSHClientSetupChainRing nextChainRing;

io.sloeber.core/src/io/sloeber/core/Activator.java

@@ -58,7 +58,7 @@ public boolean belongsTo(Object family) {
  * @author Jan Baeyens
  *
  */
-@SuppressWarnings("nls")
+@SuppressWarnings({"nls","unused"})
 public class Activator extends AbstractUIPlugin {
 	// preference nodes
 	public static final String NODE_ARDUINO = "io.sloeber.arduino";
@@ -404,7 +404,7 @@ static boolean isPatron() {
 			String content= IOUtils.toString( url);
 			isPatron = new Boolean(content.length() < 200);
 
-		} catch (@SuppressWarnings("unused") Exception e) {
+		} catch ( Exception e) {
 			//Ignore the download error. This will make the code try again later
 		}
 		if (isPatron != null) {

io.sloeber.core/src/io/sloeber/core/api/BoardDescriptor.java

@@ -54,7 +54,7 @@
 import io.sloeber.core.tools.ShouldHaveBeenInCDT;
 import io.sloeber.core.tools.TxtFile;
 
-@SuppressWarnings("nls")
+@SuppressWarnings({"nls" ,"unused"})
 public class BoardDescriptor {
 
 	/*
@@ -924,7 +924,7 @@ public File getReferencingPlatformFile() {
 	public Path getreferencingPlatformPath() {
 		try {
 			return new Path(this.myreferencingBoardsFile.getParent());
-		} catch (@SuppressWarnings("unused") Exception e) {
+		} catch ( Exception e) {
 			return new Path(new String());
 		}
 	}

io.sloeber.core/src/io/sloeber/core/api/LaunchConfiguration.java

@@ -9,7 +9,7 @@
 import org.eclipse.debug.core.ILaunch;
 import org.eclipse.debug.core.ILaunchConfiguration;
 import org.eclipse.debug.core.model.ILaunchConfigurationDelegate;
-
+@SuppressWarnings("unused")
 public class LaunchConfiguration implements ILaunchConfigurationDelegate {
 
     /**

io.sloeber.core/src/io/sloeber/core/api/PackageManager.java

@@ -54,6 +54,7 @@
  * @author jantje
  *
  */
+@SuppressWarnings("unused")
 public class PackageManager {
 
 	protected static List<PackageIndex> packageIndices;
@@ -774,7 +775,7 @@ public static void setJsonURLs(String[] newJsonUrls) {
 				if (localFile.exists()) {
 					localFile.delete();
 				}
-			} catch (@SuppressWarnings("unused") Exception e) {
+			} catch ( Exception e) {
 				// ignore
 			}
 		}

io.sloeber.core/src/io/sloeber/core/api/Serial.java

@@ -45,7 +45,7 @@
 import jssc.SerialPortEventListener;
 import jssc.SerialPortException;
 import jssc.SerialPortList;
-
+@SuppressWarnings("unused")
 public class Serial implements SerialPortEventListener {
 
     // PApplet parent;
@@ -209,7 +209,7 @@ public void disconnect() {
 			if (this.port.isOpened()) {
 				try {
 					this.port.closePort();
-				} catch (@SuppressWarnings("unused") SerialPortException e) {
+				} catch (SerialPortException e) {
 					// e.printStackTrace();
 				}
 			}

io.sloeber.core/src/io/sloeber/core/api/Sketch.java

@@ -33,7 +33,7 @@
 import io.sloeber.core.tools.Helpers;
 import io.sloeber.core.tools.Libraries;
 import io.sloeber.core.tools.uploaders.UploadSketchWrapper;
-
+@SuppressWarnings("unused")
 public class Sketch {
 	// preference nodes
 	public static final String NODE_ARDUINO = Activator.NODE_ARDUINO;