Skip to content

Commit 680b666

Browse files
author
jantje
committed
Fixing lot of warnings and info's
mostly turning warnings off
1 parent 32bdfcd commit 680b666

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+122
-114
lines changed

‎io.sloeber.core/src/cc/arduino/packages/ssh/NoInteractionUserInfo.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131

3232
import com.jcraft.jsch.UserInfo;
3333

34-
@SuppressWarnings({ "unqualified-field-access" })
34+
//@SuppressWarnings({ "unqualified-field-access" })
3535
public class NoInteractionUserInfo implements UserInfo {
3636

3737
private final String password;

‎io.sloeber.core/src/cc/arduino/packages/ssh/SCP.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
import com.jcraft.jsch.ChannelExec;
4040
import com.jcraft.jsch.Session;
4141

42-
@SuppressWarnings({ "unused", "nls", "unqualified-field-access" })
42+
@SuppressWarnings({ "unused", "nls" })
4343
public class SCP extends SSH {
4444

4545
private Channel channel;

‎io.sloeber.core/src/cc/arduino/packages/ssh/SSH.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
import com.jcraft.jsch.JSchException;
4040
import com.jcraft.jsch.Session;
4141

42-
@SuppressWarnings({ "nls", "unqualified-field-access" })
42+
@SuppressWarnings({ "nls","unused" })
4343
public class SSH {
4444

4545
final Session session;

‎io.sloeber.core/src/cc/arduino/packages/ssh/SSHConfigFileSetup.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040

4141
import cc.arduino.packages.BoardPort;
4242

43-
@SuppressWarnings({ "nls", "unqualified-field-access" })
43+
@SuppressWarnings({ "nls" })
4444
public class SSHConfigFileSetup implements SSHClientSetupChainRing {
4545

4646
private final SSHClientSetupChainRing nextChainRing;

‎io.sloeber.core/src/io/sloeber/core/Activator.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public boolean belongsTo(Object family) {
5858
* @author Jan Baeyens
5959
*
6060
*/
61-
@SuppressWarnings("nls")
61+
@SuppressWarnings({"nls","unused"})
6262
public class Activator extends AbstractUIPlugin {
6363
// preference nodes
6464
public static final String NODE_ARDUINO = "io.sloeber.arduino";
@@ -404,7 +404,7 @@ static boolean isPatron() {
404404
String content= IOUtils.toString( url);
405405
isPatron = new Boolean(content.length() < 200);
406406

407-
} catch (@SuppressWarnings("unused") Exception e) {
407+
} catch ( Exception e) {
408408
//Ignore the download error. This will make the code try again later
409409
}
410410
if (isPatron != null) {

‎io.sloeber.core/src/io/sloeber/core/api/BoardDescriptor.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
import io.sloeber.core.tools.ShouldHaveBeenInCDT;
5555
import io.sloeber.core.tools.TxtFile;
5656

57-
@SuppressWarnings("nls")
57+
@SuppressWarnings({"nls" ,"unused"})
5858
public class BoardDescriptor {
5959

6060
/*
@@ -924,7 +924,7 @@ public File getReferencingPlatformFile() {
924924
public Path getreferencingPlatformPath() {
925925
try {
926926
return new Path(this.myreferencingBoardsFile.getParent());
927-
} catch (@SuppressWarnings("unused") Exception e) {
927+
} catch ( Exception e) {
928928
return new Path(new String());
929929
}
930930
}

‎io.sloeber.core/src/io/sloeber/core/api/LaunchConfiguration.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import org.eclipse.debug.core.ILaunch;
1010
import org.eclipse.debug.core.ILaunchConfiguration;
1111
import org.eclipse.debug.core.model.ILaunchConfigurationDelegate;
12-
12+
@SuppressWarnings("unused")
1313
public class LaunchConfiguration implements ILaunchConfigurationDelegate {
1414

1515
/**

‎io.sloeber.core/src/io/sloeber/core/api/PackageManager.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
* @author jantje
5555
*
5656
*/
57+
@SuppressWarnings("unused")
5758
public class PackageManager {
5859

5960
protected static List<PackageIndex> packageIndices;
@@ -774,7 +775,7 @@ public static void setJsonURLs(String[] newJsonUrls) {
774775
if (localFile.exists()) {
775776
localFile.delete();
776777
}
777-
} catch (@SuppressWarnings("unused") Exception e) {
778+
} catch ( Exception e) {
778779
// ignore
779780
}
780781
}

‎io.sloeber.core/src/io/sloeber/core/api/Serial.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
import jssc.SerialPortEventListener;
4646
import jssc.SerialPortException;
4747
import jssc.SerialPortList;
48-
48+
@SuppressWarnings("unused")
4949
public class Serial implements SerialPortEventListener {
5050

5151
// PApplet parent;
@@ -209,7 +209,7 @@ public void disconnect() {
209209
if (this.port.isOpened()) {
210210
try {
211211
this.port.closePort();
212-
} catch (@SuppressWarnings("unused") SerialPortException e) {
212+
} catch (SerialPortException e) {
213213
// e.printStackTrace();
214214
}
215215
}

‎io.sloeber.core/src/io/sloeber/core/api/Sketch.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
import io.sloeber.core.tools.Helpers;
3434
import io.sloeber.core.tools.Libraries;
3535
import io.sloeber.core.tools.uploaders.UploadSketchWrapper;
36-
36+
@SuppressWarnings("unused")
3737
public class Sketch {
3838
// preference nodes
3939
public static final String NODE_ARDUINO = Activator.NODE_ARDUINO;

‎io.sloeber.core/src/io/sloeber/core/api/VersionNumber.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
package io.sloeber.core.api;
2-
2+
@SuppressWarnings("unused")
33
public class VersionNumber implements Comparable<Object> {
44
private String[] parts;
55

‎io.sloeber.core/src/io/sloeber/core/common/Common.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
import io.sloeber.core.Activator;
2626

27-
@SuppressWarnings("nls")
27+
@SuppressWarnings({"nls","unused"})
2828
public class Common extends Const {
2929
private static final String ENV_PATTERN = "PATTERN";
3030
private static final String ENV_PROTOCOL = "PROTOCOL";

‎io.sloeber.core/src/io/sloeber/core/common/ConfigurationPreferences.java

+1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
* @author jan
3232
*
3333
*/
34+
@SuppressWarnings("unused")
3435
public class ConfigurationPreferences {
3536

3637
private static String stringSplitter = "\n";//$NON-NLS-1$

‎io.sloeber.core/src/io/sloeber/core/common/IndexHelper.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import org.eclipse.core.resources.IProject;
1616
import org.eclipse.core.runtime.CoreException;
1717
import org.eclipse.core.runtime.NullProgressMonitor;
18-
18+
@SuppressWarnings("unused")
1919
public class IndexHelper {
2020
/**
2121
* given a list of names from the indexer. Find a function call and return

‎io.sloeber.core/src/io/sloeber/core/communication/ArduinoSerial.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import io.sloeber.core.api.Serial;
1515
import io.sloeber.core.common.Common;
1616
import io.sloeber.core.common.Const;
17-
17+
@SuppressWarnings("unused")
1818
public class ArduinoSerial {
1919

2020
private ArduinoSerial() {
@@ -30,6 +30,7 @@ private ArduinoSerial() {
3030
* The baud rate to set
3131
* @return true is successful otherwise false
3232
*/
33+
3334
public static boolean reset_Arduino_by_baud_rate(String comPort, int baudRate, long openTime) {
3435
Serial serialPort;
3536
try {

‎io.sloeber.core/src/io/sloeber/core/listeners/ConfigurationChangeListener.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
import io.sloeber.core.common.Const;
3131
import io.sloeber.core.tools.Helpers;
3232
import io.sloeber.core.tools.Libraries;
33-
33+
@SuppressWarnings({"unused"})
3434
public class ConfigurationChangeListener implements ICProjectDescriptionListener {
3535

3636
@Override

‎io.sloeber.core/src/io/sloeber/core/managers/HierarchicalProperties.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import java.util.List;
1313
import java.util.Map;
1414
import java.util.Properties;
15-
15+
@SuppressWarnings("unused")
1616
public class HierarchicalProperties {
1717

1818
private String value;

‎io.sloeber.core/src/io/sloeber/core/toolchain/ArduinoGnuMakefileGenerator.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -3297,9 +3297,8 @@ static public String escapeWhitespaces(String path) {
32973297
}
32983298
}
32993299
return escapedPath.toString().trim();
3300-
}else {
3301-
return path;
33023300
}
3301+
return path;
33033302
}
33043303

33053304
/**

‎io.sloeber.core/src/io/sloeber/core/toolchain/ArduinoLanguageProvider.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import io.sloeber.core.common.Common;
1313
import io.sloeber.core.common.Const;
1414

15-
@SuppressWarnings("nls")
15+
@SuppressWarnings({"nls","unused"})
1616
public class ArduinoLanguageProvider extends GCCBuiltinSpecsDetector{
1717

1818

‎io.sloeber.core/src/io/sloeber/core/toolchain/ArduinoManagedBuildGnuToolInfo.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
*
4949
* @noextend This class is not intended to be subclassed by clients.
5050
*/
51-
@SuppressWarnings({ "restriction", "deprecation" })
51+
@SuppressWarnings({ "restriction", "deprecation" ,"unused"})
5252
public class ArduinoManagedBuildGnuToolInfo implements IManagedBuildGnuToolInfo {
5353

5454
/*

‎io.sloeber.core/src/io/sloeber/core/tools/ExternalCommandLauncher.java

+1
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@
5555
* @since 2.2
5656
*
5757
*/
58+
@SuppressWarnings("unused")
5859
public class ExternalCommandLauncher {
5960

6061
/** Lock for internal synchronization */

‎io.sloeber.core/src/io/sloeber/core/tools/Helpers.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
import io.sloeber.core.managers.Tool;
6868
import io.sloeber.core.managers.ToolDependency;
6969

70-
@SuppressWarnings("nls")
70+
@SuppressWarnings({"nls","unused"})
7171
/**
7272
* ArduinoHelpers is a static class containing general purpose functions
7373
*

‎io.sloeber.core/src/io/sloeber/core/tools/Libraries.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
import io.sloeber.core.common.Const;
4646
import io.sloeber.core.common.InstancePreferences;
4747
import io.sloeber.core.managers.Library;
48-
48+
@SuppressWarnings("unused")
4949
public class Libraries {
5050
public static final String WORKSPACE_LIB_FOLDER = "libraries/"; //$NON-NLS-1$
5151

‎io.sloeber.core/src/io/sloeber/core/tools/PdePreprocessor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
import org.eclipse.core.runtime.IPath;
5252
import org.eclipse.core.runtime.Path;
5353

54-
@SuppressWarnings({ "nls", "restriction" })
54+
@SuppressWarnings({ "nls", "restriction","unused" })
5555
public class PdePreprocessor {
5656
private static String oldGeneratedFile = ".ino.cpp";// somethimes having the
5757
// file hidden is

‎io.sloeber.core/src/io/sloeber/core/tools/TxtFile.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ public String[] getAllNames() {
200200
*
201201
*/
202202
public String[] getAllNames(String[] toaddNames) {
203-
if (this.mLastLoadedTxtFile.equals(new String())) {
203+
if (this.mLastLoadedTxtFile.toString().equals(new String())) {
204204
return toaddNames;
205205
}
206206
HashSet<String> allNames = new HashSet<>();

‎io.sloeber.core/src/io/sloeber/core/tools/Version.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
package io.sloeber.core.tools;
2-
2+
@SuppressWarnings("unused")
33
public class Version {
44
/**
55
* compares 2 strings as if they are version numbers if version1<version2

0 commit comments

Comments
 (0)