Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the naming discrepancy (path_) of referenced to_disk=True object #216

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Remove the naming discrepancy (path_) of referenced to_disk=True object #216

merged 3 commits into from
Nov 2, 2023

Conversation

mpvanderschelling
Copy link
Collaborator

@mpvanderschelling mpvanderschelling commented Nov 2, 2023 •
edited
Loading

Bug-fixes

Major change

  • If you call the property ExperimentSample.output_data, the loaded object is returned (this is different from previous versions). The alias .output_data_loaded does the same and is kept for backwards compatibility.
  • If you want to get the references, you can use ExperimentSample.output_data_with_references

@mpvanderschelling mpvanderschelling mentioned this pull request Nov 2, 2023
Closed
@mpvanderschelling mpvanderschelling marked this pull request as ready for review November 2, 2023 21:03
@mpvanderschelling mpvanderschelling self-assigned this Nov 2, 2023
@mpvanderschelling mpvanderschelling removed the request for review from BernardoFerreira November 2, 2023 21:46
@mpvanderschelling mpvanderschelling merged commit 85e6a88 into pr/1.4.5 Nov 2, 2023
@mpvanderschelling mpvanderschelling deleted the mpvanderschelling/issue212 branch November 2, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mpvanderschelling mpvanderschelling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mpvanderschelling