Fix PDFWriter #41
Merged
Fix PDFWriter #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Can you please remove the unrelated changes (changing bookmark to outline item)? |
Deprecated since version 1.28.0: Use add_outline_item() instead. |
|
Is there more left to do on this one? Happy to help. |
|
Looks like issue solved as I wrote about changing bookmark to outline item it's the same old ver deprecated stuff |
|
Merged. Thanks for the work, I hadn't seen your reply explaining the outline thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing this issue: PdfFileWriter is deprecated and was removed in PyPDF2 3.0.0. Use PdfWriter instead. #40