-
Notifications
You must be signed in to change notification settings - Fork 181
Site: Rework Lua API appearance and functionality #2570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Site: Rework Lua API appearance and functionality #2570
Conversation
Just a heads up, the splinterfaction image is linking to https://beyond-all-reason.github.io/RecoilEngine/splinterfaction.info instead of https://splinterfaction.info/ |
I see what's wrong with the see and the links, by the way; The permalink generator does not take the type of thing it is into account, so anything with the same name under the same scope will have the same link, whether it's an alias or a property. A simple enough fix. |
Also cc @rhys-vdw |
https://github.com/beyond-all-reason/RecoilEngine/blob/master/doc/site/docgen/templates.rb#L10-L11 |
What am I looking at here? is the margin-top span the trick? Also, TODO: Add aria labels. |
…ain in the future there will need to be proper analysis
…oilEngine into site_formatting_template
Can we get a link to a version of this on the web? |
Overall this is looking pretty sweet. I assume this is all on one page by popular demand, so I won't push back on that. |
Note alias truncation has been resolved quite a while ago. I commented on discord, but this PR should reference and use the most recent version of emmylua (change pinned version). |
Sorry, bad mouse press |
Still happens with 0.13.0, I tested locally. |
I know it's not ideal, but it's the easiest. |
@@ -1,8 +1,8 @@ | |||
{{/* | |||
Emmylua does this thing where either the type is truncated or the entire fucking alias is put in the type field. | |||
So this partial is for extracting a type name from a string, since that needs to be done in a few places. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like something that could be raised with emmylua (or even PR'd in) rather than hacked around here. Just a thought.
I raised an issue about it. It either is truncated or the entire thing is in the type annotation. I’ll grab the issue when I’m back on my pc in a bit.
… Message ID: ***@***.***>
|
I aim to make the API docs easier to use and to look at. It is now one monolithic doc page, but the TOC should make it possible to navigate. I also aim to remove external markdown generation and make everything except the JSON generation itself within Hugo to have a single place to control all content and appearance.
Comments are welcome, but I know I won't please everybody- and trying to do so is a futile effort.
(edit from @badosu) Deployed at https://slashscreen.github.io/RecoilEngine/docs/lua-api/