Skip to content

Conversation

SlashScreen
Copy link
Contributor

@SlashScreen SlashScreen commented Sep 10, 2025

I aim to make the API docs easier to use and to look at. It is now one monolithic doc page, but the TOC should make it possible to navigate. I also aim to remove external markdown generation and make everything except the JSON generation itself within Hugo to have a single place to control all content and appearance.

  • Rework API appearance
  • Generate TOC
  • Collapsible members
  • Backlink generation
  • Type parsing and backlink generation
  • Polish (verb) appearance
  • Restore TOCs to other generated sites like weapon defs and synced commands
  • Remove Ruby scripts (sorry badosu)
  • Test with Rml UI, since it has nested classes
  • Optimize? (takes about a second to build the whole site, roughly 2/3rds of which is the API page, which I do not like)
  • Optimize styles for maintainability and single place of control mantra.
  • Document code, especially since templates are very difficult to read
  • Make TOC look more similar to the hextra one? Do we care? It's been a struggle to do that.
  • Fix favicon
  • Finishing touches
  • Aria labels

Comments are welcome, but I know I won't please everybody- and trying to do so is a futile effort.

(edit from @badosu) Deployed at https://slashscreen.github.io/RecoilEngine/docs/lua-api/

@ScarylePoo
Copy link
Collaborator

Just a heads up, the splinterfaction image is linking to https://beyond-all-reason.github.io/RecoilEngine/splinterfaction.info instead of https://splinterfaction.info/

@SlashScreen
Copy link
Contributor Author

@sprunk @badosu ready for merge.

@badosu
Copy link
Collaborator

badosu commented Sep 16, 2025

This is not a review pass.

A quick glance for some feedback:

  1. Use the trick I was using for the css of the anchor link so the top menu does not cover the anchor position
  2. Enums dont seem to be working
image 3. See: does not seem to be working

@SlashScreen
Copy link
Contributor Author

Alright, I will take a look. Where can I see the trick?

This is not a review pass.

A quick glance for some feedback:

1. Use the trick I was using for the css of the anchor link so the top menu does not cover the anchor position

2. Enums dont seem to be working

image 3. See: does not seem to be working

@SlashScreen
Copy link
Contributor Author

I see what's wrong with the see and the links, by the way; The permalink generator does not take the type of thing it is into account, so anything with the same name under the same scope will have the same link, whether it's an alias or a property. A simple enough fix.

@SlashScreen
Copy link
Contributor Author

Also cc @rhys-vdw

@badosu
Copy link
Collaborator

badosu commented Sep 16, 2025

@SlashScreen
Copy link
Contributor Author

What am I looking at here? is the margin-top span the trick?

Also, TODO: Add aria labels.

…ain in the future there will need to be proper analysis
@rhys-vdw
Copy link
Collaborator

Can we get a link to a version of this on the web?

@rhys-vdw
Copy link
Collaborator

Markdown is getting flattened. You may accidentally be trimming the start of the doc lines.

image

This is mean to be a tree of nested lists.

@rhys-vdw
Copy link
Collaborator

Currently the design is absolutely dominated by the word "property", "table" and so on.
image

Can I suggest subduing it a bit?
image

@rhys-vdw
Copy link
Collaborator

Probably goes without saying, but this is not working:
image

Something more like:

alias Attachment

(“depth”|“stencil”|“color0”|“color1”|“color2”|“color3”|“color4”|“color5”…) 

Description here


@rhys-vdw
Copy link
Collaborator

rhys-vdw commented Sep 17, 2025

image

Same deal here.

Could be:

class Menu

Base classes: Callins, Foo, Bar

Description here

@rhys-vdw
Copy link
Collaborator

rhys-vdw commented Sep 17, 2025

Overall this is looking pretty sweet. I assume this is all on one page by popular demand, so I won't push back on that.

@badosu
Copy link
Collaborator

badosu commented Sep 17, 2025

(“depth”|“stencil”|“color0”|“color1”|“color2”|“color3”|“color4”|“color5”…)

Note alias truncation has been resolved quite a while ago. I commented on discord, but this PR should reference and use the most recent version of emmylua (change pinned version).

@badosu badosu closed this Sep 17, 2025
@badosu badosu reopened this Sep 17, 2025
@badosu
Copy link
Collaborator

badosu commented Sep 17, 2025

Sorry, bad mouse press

@SlashScreen
Copy link
Contributor Author

(“depth”|“stencil”|“color0”|“color1”|“color2”|“color3”|“color4”|“color5”…)

Note alias truncation has been resolved quite a while ago. I commented on discord, but this PR should reference and use the most recent version of emmylua (change pinned version).

Still happens with 0.13.0, I tested locally.

@SlashScreen
Copy link
Contributor Author

Overall this is looking pretty sweet. I assume this is all on one page by popular demand, so I won't push back on that.

I know it's not ideal, but it's the easiest.

@@ -1,8 +1,8 @@
{{/*
Emmylua does this thing where either the type is truncated or the entire fucking alias is put in the type field.
So this partial is for extracting a type name from a string, since that needs to be done in a few places.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like something that could be raised with emmylua (or even PR'd in) rather than hacked around here. Just a thought.

@SlashScreen
Copy link
Contributor Author

SlashScreen commented Oct 2, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants