Merge pull request #22 from lucasmichot/feature/commands

No need to construct both descriptors.

Author: mpociot

src/DumpServerCommand.php

@@ -20,44 +20,55 @@ class DumpServerCommand extends Command
      *
      * @var string
      */
-    protected $signature = 'dump-server {--format=cli : The output format (cli,html)}';
+    protected $signature = 'dump-server {--format=cli : The output format (cli,html).}';
 
     /**
      * The console command description.
      *
      * @var string
      */
-    protected $description = 'Start the dump server to collect dump information';
+    protected $description = 'Start the dump server to collect dump information.';
 
-    /** @var DumpServer  */
+    /**
+     * The Dump server.
+     *
+     * @var \Symfony\Component\VarDumper\Server\DumpServer
+     */
     private $server;
 
     /**
-     * @var \Symfony\Component\VarDumper\Command\Descriptor\DumpDescriptorInterface[]
+     * DumpServerCommand constructor.
+     *
+     * @param  \Symfony\Component\VarDumper\Server\DumpServer  $server
+     * @return void
      */
-    private $descriptors;
-
     public function __construct(DumpServer $server)
     {
         $this->server = $server;
 
-        $this->descriptors = [
-            'cli' => new CliDescriptor(new CliDumper()),
-            'html' => new HtmlDescriptor(new HtmlDumper()),
-        ];
-
         parent::__construct();
     }
 
+    /**
+     * Handle the command.
+     *
+     * @return void
+     */
     public function handle()
     {
-        $io = new SymfonyStyle($this->input, $this->output);
-        $format = $this->option('format');
-
-        if (! $descriptor = $this->descriptors[$format] ?? null) {
-            throw new InvalidArgumentException(sprintf('Unsupported format "%s".', $format));
+        switch ($format = $this->option('format')) {
+            case 'cli':
+                $descriptor = new CliDescriptor(new CliDumper);
+                break;
+            case 'html':
+                $descriptor = new HtmlDescriptor(new HtmlDumper);
+                break;
+            default:
+                throw new InvalidArgumentException(sprintf('Unsupported format "%s".', $format));
         }
 
+        $io = new SymfonyStyle($this->input, $this->output);
+
         $errorIo = $io->getErrorStyle();
         $errorIo->title('Laravel Var Dump Server');