Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Commit

Permalink
Removed Laravel 6.x and PHP ^7.2
Browse files Browse the repository at this point in the history
  • Loading branch information
@rennokki
rennokki authored Nov 20, 2020
1 parent c0bad6d commit c50e246
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,22 +35,22 @@
"evenement/evenement": "^2.0|^3.0",
"facade/ignition-contracts": "^1.0",
"guzzlehttp/psr7": "^1.5",
"illuminate/broadcasting": "^6.3|^7.0|^8.0",
"illuminate/console": "^6.3|^7.0|^8.0",
"illuminate/http": "^6.3|^7.0|^8.0",
"illuminate/queue": "^6.3|^7.0|^8.0",
"illuminate/routing": "^6.3|^7.0|^8.0",
"illuminate/support": "^6.3|^7.0|^8.0",
"illuminate/broadcasting": "^7.0|^8.0",
"illuminate/console": "^7.0|^8.0",
"illuminate/http": "^7.0|^8.0",
"illuminate/queue": "^7.0|^8.0",
"illuminate/routing": "^7.0|^8.0",
"illuminate/support": "^7.0|^8.0",
"pusher/pusher-php-server": "^4.0",
"react/promise": "^2.0",
"symfony/http-kernel": "^4.0|^5.0",
"symfony/psr-http-message-bridge": "^1.1|^2.0"
},
"require-dev": {
"clue/block-react": "^1.4",
"laravel/legacy-factories": "^1.0.4",
"orchestra/testbench-browser-kit": "^4.0|^5.0|^6.0",
"orchestra/database": "^4.0|^5.0|^6.0",
"laravel/legacy-factories": "^1.1",
"orchestra/testbench-browser-kit": "^5.0|^6.0",
"orchestra/database": "^5.0|^6.0",
"phpunit/phpunit": "^8.0|^9.0"
},
"suggest": {
Expand Down

5 comments on commit c50e246

@canthis
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rennokki Any chance getting Laravel 6 support back? Considering Laravel 6 is LTS release and laravel-websockets 2.x works well with it I don't see reason to drop support.
octobercms/october is using Laravel 6 as foundation framework and I used it successfully with laravel-websockets 2.x

@rennokki
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reverted it, thinking that the drop would compensate with the PHP 8.0 version, since 6.x needs ^7.2, and will be dropped soon. But I was kinda dumb, it seems like 6.x still constraints for PHP 8.0. The only thing is that the testing will work for PHP 7.3+ due to the constraints.

@rennokki
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@canthis Reverted it in https://github.com/beyondcode/laravel-websockets/releases/tag/2.0.0-beta.29

@rennokki
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@canthis The tag was accidentally made from the master branch, beta.30 fixes the issue. https://github.com/beyondcode/laravel-websockets/releases/tag/2.0.0-beta.30

@canthis
Copy link

@canthis canthis commented on c50e246 Nov 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thanks for your work @rennokki 👍

Please sign in to comment.