-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Dependencies - React 18 #372
Open
ds17f
wants to merge
16
commits into
bfirsh:master
Choose a base branch
from
ds17f:upgrade-depenedencies
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some build warnings related to bootstrap
It looks like |
This was referenced Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to work with this project and modern components I ran into a lot of issues with React versions. I also saw that the node requirement was out of date. I set out to upgrade react, and any other significant dependencies.
At this time, there are still some minor warnings during an initial
yarn install
. I wasn't able to upgraderaven-js
->@sentry/browser
and I'll leave that work to somebody else as it doesn't seem to be breaking the builds or causing havock.Please take a look at the
package.json
for a complete list of the upgrades and changes, but here are some notes:react-router-dom
: a significant upgrade from 4x -> 6x. Fortunately the router stuff was relatively simple and the upgrade didn't involve a tremendous amount of work.react
: Moving to18
required some changes to the initial startup inindex.js
, but this probably wasn't particularly impactful.node-sass
: replaced withsass
asnode-sass
is deprecated.bootstrap
: upgraded to 5. I'll admit that I just hacked the css to make it look like the old version. I'm sure there are better ways to do this, and somebody familiar with bootstrap and css might take that work on.jsnes
via github. It didn't work for me onyarn
as it was, but works now.I bumped the major version of the project from
0.x
to1.x
. These changes are NOT backwards compatible, so we should bump the major version. With that said,semver
says to stay on0.x
branch if you're "Pre-release." I'm not sure if this project is. I'm open to changes to thesemver
if a project maintainer feels that it shouldn't be1.0.0
.