Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Dependencies - React 18 #372

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

ds17f
Copy link

@ds17f ds17f commented Aug 25, 2022

When trying to work with this project and modern components I ran into a lot of issues with React versions. I also saw that the node requirement was out of date. I set out to upgrade react, and any other significant dependencies.

At this time, there are still some minor warnings during an initial yarn install. I wasn't able to upgrade raven-js -> @sentry/browser and I'll leave that work to somebody else as it doesn't seem to be breaking the builds or causing havock.

Please take a look at the package.json for a complete list of the upgrades and changes, but here are some notes:

  • react-router-dom: a significant upgrade from 4x -> 6x. Fortunately the router stuff was relatively simple and the upgrade didn't involve a tremendous amount of work.
  • react: Moving to 18 required some changes to the initial startup in index.js, but this probably wasn't particularly impactful.
  • node-sass: replaced with sass as node-sass is deprecated.
  • bootstrap: upgraded to 5. I'll admit that I just hacked the css to make it look like the old version. I'm sure there are better ways to do this, and somebody familiar with bootstrap and css might take that work on.
  • Updated the URL for the install of jsnes via github. It didn't work for me on yarn as it was, but works now.

I bumped the major version of the project from 0.x to 1.x. These changes are NOT backwards compatible, so we should bump the major version. With that said, semver says to stay on 0.x branch if you're "Pre-release." I'm not sure if this project is. I'm open to changes to the semver if a project maintainer feels that it shouldn't be 1.0.0.

@ds17f
Copy link
Author

ds17f commented Aug 25, 2022

It looks like deploy/netlify is breaking because of an old version of ubuntu. I don't know how to fix that but would be happy to if it can be done as part of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant