Added type to the ErrorBoundary.tsx component #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ishan-1101 is attempting to deploy a commit to the BGWebAgency Team on Vercel. A member of the Team first needs to authorize it. |
|
@Ishan-1101 Thanks for the PR! I will review it soon :) |
|
Issue: convert ErrorBoundary.jsx to ErrorBoundary.tsx #9 resolved, please check and merge |
kirandash
requested changes
Jun 14, 2023
There was a problem hiding this comment.
Hi @Ishan-1101
Can you please fix the errors first. Before I can review rest of the file.
Currently the errors are causing the build to fail.
If you need any help, feel free to reach me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added these Types and converted class based jsx component into Functional tsx .
Fixes #9