Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update missing metadata to qMRI sequences #482

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

effigies
Copy link
Contributor

After merging bids-standard/bids-specification#2020, attempting to update the schema for the validator produces:

  ┌─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ qmri_mtsat                                                                                                      │
  └─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
    SIDECAR_KEY_REQUIRED -               /sub-01/anat/sub-01_flip-1_mt-off_MTS.ni                                    
    RepetitionTimeExcitation             i.gz                                                                        
                                                                                                                     
    SIDECAR_KEY_REQUIRED -               /sub-01/anat/sub-01_flip-1_mt-on_MTS.nii                                    
    RepetitionTimeExcitation             .gz                                                                         
                                                                                                                     
    SIDECAR_KEY_REQUIRED -               /sub-01/anat/sub-01_flip-2_mt-off_MTS.ni                                    
    RepetitionTimeExcitation             i.gz                                                                        
  ┌─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ qmri_sa2rage                                                                                                    │
  └─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
    SIDECAR_KEY_REQUIRED - NumberShots   /sub-01/fmap/sub-01_flip-1_inv-1_TB1SRGE                                    
                                         .nii.gz                                                                     
                                                                                                                     
    SIDECAR_KEY_REQUIRED - NumberShots   /sub-01/fmap/sub-01_flip-2_inv-2_TB1SRGE                                    
                                         .nii.gz                                                                     
  ┌─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ qmri_vfa                                                                                                        │
  └─────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
    SIDECAR_KEY_REQUIRED -               /sub-01/anat/sub-01_flip-1_VFA.nii.gz                                       
    RepetitionTimeExcitation                                                                                         
                                                                                                                     
    SIDECAR_KEY_REQUIRED -               /sub-01/anat/sub-01_flip-2_VFA.nii.gz                                       
    RepetitionTimeExcitation                                                                                         
                                                                                                                     
    SIDECAR_KEY_REQUIRED -               /sub-01/fmap/sub-01_acq-tr1_TB1AFI.nii.g                                    
    RepetitionTimeExcitation             z                                                                           
                                                                                                                     
    SIDECAR_KEY_REQUIRED -               /sub-01/fmap/sub-01_acq-tr2_TB1AFI.nii.g                                    
    RepetitionTimeExcitation             z  

In most cases, the problem is that RepetitionTime is used instead of RepetitionTimeExcitation in qMRI sequences. I updated across the board, even for those where it is not a required field.

For qmri_sa2rage, the NumberShots field is required, but absent. I don't know how to derive it; there's nothing in the paper (doi:10.1002/mrm.23145), so I just set it to 1.

@agahkarakuzu @ChristophePhillips This affects examples you've provided. Can you please review these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant