Skip to content

Conversation

cookpa
Copy link
Contributor

@cookpa cookpa commented Sep 16, 2024

Fixes #1086

@effigies
Copy link
Collaborator

Thanks. We have a bids_examples fixture:

pybids/bids/conftest.py

Lines 41 to 52 in 95c7aa9

def bids_examples():
examples_dir = Path(os.getenv(
"BIDS_EXAMPLES",
Path(__file__).absolute().parent.parent / "bids-examples"
))
if not Path.is_dir(examples_dir / "ds001"):
pytest.skip(
f"BIDS examples missing from {examples_dir}. "
"Override default location with BIDS_EXAMPLES environment variable."
)
return examples_dir

I think you should be able to create a test using one of the example datasets (https://github.com/bids-standard/bids-examples) that demonstrates this error?

@codecov
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (95c7aa9) to head (6ecffc7).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1087      +/-   ##
==========================================
+ Coverage   89.75%   89.77%   +0.02%     
==========================================
  Files          63       63              
  Lines        7123     7141      +18     
  Branches     1364     1367       +3     
==========================================
+ Hits         6393     6411      +18     
  Misses        531      531              
  Partials      199      199              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Collaborator

Thanks!

@effigies effigies merged commit b6d1b29 into bids-standard:master Sep 18, 2024
24 checks passed
@effigies
Copy link
Collaborator

@cookpa Would you like to be listed as a contributor in releases? https://github.com/bids-standard/pybids/blob/master/.zenodo.json

@cookpa
Copy link
Contributor Author

cookpa commented Sep 19, 2024

Sure, thanks! I'll edit the file

@effigies
Copy link
Collaborator

Feel free to just paste your snippet here and I'll include it in the release process. (A PR is also fine if you're already in the middle of it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Layout does not follow symbolic links to directories in pybids>=0.17.0

2 participants