Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail gracefully on IGV attempts to open invalid SODAR URLs #2075

Open
mikkonie opened this issue Feb 20, 2025 · 2 comments
Open

Fail gracefully on IGV attempts to open invalid SODAR URLs #2075

mikkonie opened this issue Feb 20, 2025 · 2 comments
Assignees
Labels
app: samplesheets Issue in the samplesheets app environment Issues of dependencies, CI, deployment etc. feature Requested feature or enhancement
Milestone

Comments

@mikkonie
Copy link
Contributor

Something I noticed when testing IGV integration for SODAR v1.0.0-WIP in staging.

After opening a session file, IGV performs another request to SODAR using the session serving URL, followed by the genome ID. This of course fails as this is not a valid URL. Example in IGV log:

INFO [Feb 20,2025 13:04] [GenomeManager] Loading genome: https://sodar-staging.bihealth.org/samplesheets/study/germline/render/igv/b37_1kg
SEVERE [Feb 20,2025 13:04] [MessageUtils] Error loading genome: b37_1kg
SEVERE [Feb 20,2025 13:04] [MessageUtils] org.broad.igv.exceptions.HttpResponseException: Internal Server Error

I'm not sure what is happening here. I did get an error message when starting up IGV about not being able to load the genome, so I suppose these are somehow related?

IGV experts, feel free to chime in. What should be done about this on the SODAR side?

Does this also happen in SODAR v0.15.1 if certain conditions are met? If so, which conditions?

At the very least, we should probably return with a more graceful error than a dump of the 500 error HTML. Since these requests always hit the same study app views, that would be doable.

I tested this with IGV v2.19.1, with b37_1kg as the genome.

@mikkonie mikkonie added bug Something isn't working environment Issues of dependencies, CI, deployment etc. ongoing Ongoing issue, needs observation or pending on other projects app: samplesheets Issue in the samplesheets app help wanted Extra attention is needed labels Feb 20, 2025
@mikkonie
Copy link
Contributor Author

I can confirm this also happens to me on v0.15.1 running in production at the time of writing. I'm guessing it's related to how I've (mis)configured IGV.

This is also related to #1795, as I also see those errors when this happens.

@mikkonie
Copy link
Contributor Author

mikkonie commented Feb 20, 2025

Thanks to @Nicolai-vKuegelgen for helping me out with this. I simply need to choose the genome manually first, then all works.

Nevertheless, we should implement a graceful 404 error instead of a 500 internal failure, if IGV calls the server with an invalid URL. This should also enable us to close #1795.

It's not super urgent, so I'm tagging this for v1.1.

@mikkonie mikkonie removed the help wanted Extra attention is needed label Feb 20, 2025
@mikkonie mikkonie changed the title IGV attempts to open invalid SODAR URL with genome ID Fail gracefully on IGV attempts to open invalid SODAR URLs Feb 20, 2025
@mikkonie mikkonie self-assigned this Feb 20, 2025
@mikkonie mikkonie added feature Requested feature or enhancement and removed bug Something isn't working ongoing Ongoing issue, needs observation or pending on other projects labels Feb 20, 2025
@mikkonie mikkonie modified the milestones: v1.0.1, v1.1.0 Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: samplesheets Issue in the samplesheets app environment Issues of dependencies, CI, deployment etc. feature Requested feature or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant