-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video single frame annotation #1019
Conversation
@aneust Was this closed on purpose? |
@mzur Closed on purpose, Leane found some strange behavior I first could not reproduce. Think now it was caused by the settings. |
Ok, thanks. You could also keep this as a Draft PR while you keep working on the issue. |
Regarding the issue with the sketch lines: |
@lehecht Thanks, that was helpful! |
resources/assets/js/videos/components/videoScreen/drawInteractions.vue
Outdated
Show resolved
Hide resolved
resources/assets/js/videos/components/videoScreen/drawInteractions.vue
Outdated
Show resolved
Hide resolved
resources/assets/js/videos/components/videoScreen/drawInteractions.vue
Outdated
Show resolved
Hide resolved
resources/assets/js/videos/components/videoScreen/drawInteractions.vue
Outdated
Show resolved
Hide resolved
resources/assets/js/videos/components/videoScreen/drawInteractions.vue
Outdated
Show resolved
Hide resolved
resources/assets/js/videos/components/videoScreen/drawInteractions.vue
Outdated
Show resolved
Hide resolved
resources/assets/js/videos/components/videoScreen/drawInteractions.vue
Outdated
Show resolved
Hide resolved
resources/assets/js/videos/components/videoScreen/drawInteractions.vue
Outdated
Show resolved
Hide resolved
resources/assets/js/videos/components/videoScreen/drawInteractions.vue
Outdated
Show resolved
Hide resolved
resources/assets/js/videos/components/videoScreen/drawInteractions.vue
Outdated
Show resolved
Hide resolved
- update computed properties for better readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now. Please request a review from @mzur.
I saw the mention and self-requested the review 😉 @lehecht You can also request the review from me when you are done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments about the UI:
-
The setting doesn't affect whole-frame annotations but it should.
-
To be more user-friendly, the "finish annotation" and "track annotation" buttons (which are disabled) could get titles like "Disable the single-frame annotation option to create multi-frame annotations" ("Disable the single-frame annotation option to track annotations"). This way users are reminded of what to do if they want to use the buttons again. You could implement this with
v-if
showing a completely different set of buttons which are always disabled and have the new title.
Otherwise it works great. See some comments about the code below.
resources/assets/js/videos/components/videoScreen/drawInteractions.vue
Outdated
Show resolved
Hide resolved
resources/assets/js/videos/components/videoScreen/drawInteractions.vue
Outdated
Show resolved
Hide resolved
resources/assets/js/videos/components/videoScreen/drawInteractions.vue
Outdated
Show resolved
Hide resolved
resources/assets/js/videos/components/videoScreen/drawInteractions.vue
Outdated
Show resolved
Hide resolved
resources/assets/js/videos/components/videoScreen/drawInteractions.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the setting now affects whole frame annotations, I can't create these any more. The tool is activated but I no longer have a way to "finish" it. When the setting is activated, the whole frame annotation should be immediately created when the button is clicked.
Apart from that, only minor comments are left.
resources/assets/js/videos/components/videoScreen/drawInteractions.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last general comment:
When the new settings option is active, the title text of the buttons still reads "Start a point annotation", "Start a rectangle annotation", etc. It should change to something similar to the image annotation tool ("Set a point", "Draw a rectangle", ...).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now, thanks!
Add a settings option to the video annotation tool to automatically finish new annotations after the first frame
closes #786