Fix polygon tool bug #799
Merged
Fix polygon tool bug #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When interaction mode is changed, the old and new computed property change, which triggers their corresponding watchers. Fix bug by using watcher of current interaction mode only. Fixes #798
mzur
requested changes
Mar 5, 2024
mzur
reviewed
Mar 7, 2024
There was a problem hiding this comment.
This still doesn't work in all cases, unfortunately. When I now switch from the polygon brush to the magic wand tool (or any other tool), both will be active. You can tinker a little with all the tools before you submit a new version for review, then you will quickly see issues like these yourself.
The video annotation tool does this a little differently, as it has a variable for each interaction that can be added/removed separately. There, everything works correctly.
|
I tested the code multiple times for images and videos now. I think there shouldn't be bugs any more. Sorry for my hasty approach before! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When interaction mode is changed, the old and new computed property change, which triggers their corresponding watchers.
Fix bug by using watcher of current interaction mode only.