Fix failing tests

Author: lehecht

tests/Http/Controllers/Api/UserDiskControllerTest.php

@@ -185,13 +185,25 @@ public function testStoreS3PathStyle()
 
     public function testUpdate()
     {
-        $disk = UserDisk::factory()->create();
+        $disk = UserDisk::factory()->create([
+            'type' => 's3',
+            'name' => 'abc',
+            'options' => [
+                'key' => 'def',
+                'secret' => 'ghi',
+                'bucket' => 'jkl',
+                'region' => 'us-east-1',
+                'endpoint' => 'https://jkl.example.com',
+                'use_path_style_endpoint' => false,
+            ],
+        ]);
         $this->doTestApiRoute('PUT', "/api/v1/user-disks/{$disk->id}");
 
         $this->beUser();
         $this->putJson("/api/v1/user-disks/{$disk->id}")->assertStatus(403);
 
         $this->be($disk->user);
+        $this->mockS3->shouldReceive('canAccessDisk')->once()->andReturn([]);
         $this->putJson("/api/v1/user-disks/{$disk->id}")->assertStatus(200);
     }
 
@@ -300,6 +312,7 @@ public function testUpdateEmpty()
         ]);
         $this->be($disk->user);
 
+        $this->mockS3->shouldReceive('canAccessDisk')->once()->andReturn([]);
         $this->putJson("/api/v1/user-disks/{$disk->id}", [
                 'name' => 'cba',
                 'key' => '0',
@@ -474,7 +487,7 @@ public function testUpdateIncorrectBucketName()
 
         $this->be($disk->user);
 
-        $this->mockS3->shouldReceive('canAccessDisk')->once()->andReturn([]);
+        $this->mockS3->shouldReceive('canAccessDisk')->never();
         $this->putJson("/api/v1/user-disks/{$disk->id}", [
             'type' => 'unknown',
             'name' => 'cba',
@@ -486,7 +499,7 @@ public function testUpdateIncorrectBucketName()
         ])
             ->assertUnprocessable();
 
-        $this->mockS3->shouldReceive('canAccessDisk')->once()->andReturn([]);
+        $this->mockS3->shouldReceive('canAccessDisk')->never();
         $this->putJson("/api/v1/user-disks/{$disk->id}", [
             'type' => 'unknown',
             'name' => 'cba',
@@ -498,7 +511,7 @@ public function testUpdateIncorrectBucketName()
         ])
             ->assertUnprocessable();
 
-        $this->mockS3->shouldReceive('canAccessDisk')->once()->andReturn([]);
+        $this->mockS3->shouldReceive('canAccessDisk')->never();
         $this->putJson("/api/v1/user-disks/{$disk->id}", [
             'type' => 'unknown',
             'name' => 'cba',
@@ -510,7 +523,7 @@ public function testUpdateIncorrectBucketName()
         ])
             ->assertUnprocessable();
 
-        $this->mockS3->shouldReceive('canAccessDisk')->once()->andReturn([]);
+        $this->mockS3->shouldReceive('canAccessDisk')->never();
         $this->putJson("/api/v1/user-disks/{$disk->id}", [
             'type' => 'unknown',
             'name' => 'cba',