Skip to content

Commit 1b00494

Browse files
lisamuelCommit bot
authored andcommitted
Revert of Devtools: Cut color picker off at bottom instead of the top (patchset #1 id:1 of https://codereview.chromium.org/1816933002/ )
Reason for revert: Breaks color picker with no easy fix: crbug.com/603811 Original issue's description: > Devtools: Cut color picker off at bottom instead of the top > > When there is insufficent vertical space, the color picker is cut off at > the top. This change fixes it at the top in these situations, allowing > better usability of the color picker in these states. > > BUG=572101 > > Committed: https://crrev.com/acc1963c73bc1e4dabf926d5f99d9323d2918016 > Cr-Commit-Position: refs/heads/master@{#386581} [email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=572101 Review URL: https://codereview.chromium.org/1900033002 Cr-Commit-Position: refs/heads/master@{#388127}
1 parent 8c93cca commit 1b00494

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

front_end/elements/spectrum.css

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
width: 232px;
44
height: 240px;
55
-webkit-user-select: none;
6-
/* Prevents the popover from jumping when focus() is called */
7-
display: block !important;
86
}
97

108
:host(.palettes-enabled) {

front_end/ui/Popover.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ WebInspector.Popover.prototype = {
243243
}
244244

245245
this.element.className = WebInspector.Popover._classNamePrefix + " " + verticalAlignment + "-" + horizontalAlignment + "-arrow";
246-
this.element.positionAt(newElementPosition.x, Math.max(0, newElementPosition.y - borderWidth), container);
246+
this.element.positionAt(newElementPosition.x, newElementPosition.y - borderWidth, container);
247247
this.element.style.width = newElementPosition.width + borderWidth * 2 + "px";
248248
this.element.style.height = newElementPosition.height + borderWidth * 2 + "px";
249249
},

0 commit comments

Comments
 (0)