Skip to content

Commit

Permalink
Revert of DevTools: Select max resource size in NetworkResourcesData …
Browse files Browse the repository at this point in the history
…depending on device capabilities. (patchset #1 id:1 of https://codereview.chromium.org/1817523003/ )

Reason for revert:
Speculative revert to see if it fixes edit-dom-actions.html on Win7 webkit bots, which started timing out with no useful output on both Oilpan and non-Oilpan on runs including this CL (e.g., https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/5007).

Original issue's description:
> DevTools: Select max resource size in NetworkResourcesData depending on device capabilities.
>
> BUG=587982
>
> Committed: https://crrev.com/ee50736c96ca97939d5b99543f3e0b297fd88029
> Cr-Commit-Position: refs/heads/master@{#382325}

[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=587982

Review URL: https://codereview.chromium.org/1825033002

Cr-Commit-Position: refs/heads/master@{#382556}
  • Loading branch information
colinblundell authored and Commit bot committed Mar 22, 2016
1 parent 82aee18 commit 2b55c82
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
7 changes: 1 addition & 6 deletions front_end/sdk/NetworkManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,7 @@ WebInspector.NetworkManager = function(target)
this._networkAgent.setCacheDisabled(true);
if (WebInspector.moduleSetting("monitoringXHREnabled").get())
this._networkAgent.setMonitoringXHREnabled(true);

// Limit buffer when talking to a remote device.
if (Runtime.queryParam("remoteFrontend") || Runtime.queryParam("ws"))
this._networkAgent.enable(10000000, 5000000);
else
this._networkAgent.enable();
this._networkAgent.enable();

/** @type {!Map<!NetworkAgent.CertificateId, !Promise<!NetworkAgent.CertificateDetails>>} */
this._certificateDetailsCache = new Map();
Expand Down
6 changes: 1 addition & 5 deletions protocol.json
Original file line number Diff line number Diff line change
Expand Up @@ -1412,11 +1412,7 @@
"commands": [
{
"name": "enable",
"description": "Enables network tracking, network events will now be delivered to the client.",
"parameters": [
{ "name": "maxTotalBufferSize", "type": "integer", "optional": true, "hidden": true, "description": "Buffer size in bytes to use when preserving network payloads (XHRs, etc)." },
{ "name": "maxResourceBufferSize", "type": "integer", "optional": true, "hidden": true, "description": "Per-resource buffer size in bytes to use when preserving network payloads (XHRs, etc)." }
]
"description": "Enables network tracking, network events will now be delivered to the client."
},
{
"name": "disable",
Expand Down

0 comments on commit 2b55c82

Please sign in to comment.