squash 'resources/unpacked/devtools' changes from e841464..ef68b16

ef68b16 Update DevTools DEPS.
9925c6c Fix clang-format configuration
4f0f680 [COEP] Improve error messages for COEP
9b3d7b2 [docs] Update l10n docs to fix some markup
3443914 [workspaces] Don't show a console error when file select is cancelled
0340a58 Update DevTools Chromium DEPS.
a64938d Update DevTools DEPS.
760e20e Add titles for all actions
dad5ad2 Remove useless content read
3a5c518 Remove unused methods
1b0a65b Concatenate all common ts_library into a single target
888a255 [global] Remaps self.SDK.targetManager
758d716 Extract protocol generation to separate script
302e028 Update README to recommend the integrated workflow
0e35ed3 Update DevTools DEPS.
43123bf Update DevTools Chromium DEPS.
8e233b4 Update DevTools DEPS.
0c86faa Sanitizing check_localizable_resources description
0639c76 Revert "Support emulating vision deficiencies"
d5937a7 Stop rewriting html entrypoints
65fd9a0 Migrate Console and SegmentedRange tests into Ninja build
5646f9e Rename Console.ts to Console_test.ts and SegmentedRange.ts to SegmentedRange_test.ts
0edd3d1 Generate InspectorBackendCommands.js on presubmit
cf276bf Support emulating vision deficiencies
61179f7 Generate SupportedCSSProperties.js on presubmit
492f242 Remove support for devtools startup tests
a38ba7c Create `NumberUtilities` and move `constrain` in
4d59a57 Copy lit-html build files to gen folder
a055117 [global] Remaps self.Common.console
7955690 Add skipped test for breakpoints with inline scripts
08dd7ed Update DevTools DEPS.
cb538b1 Generate ARIAProperties.js on presubmit
0ae7c14 Add e2etest for shadow root styles
d05eb17 [deps] Roll deps
ff8a089 Migrate ParsedURL and ResourceType tests into Ninja build
c7c9fa5 Type check common/Linkifier.js using TypeScript
9397151 Migrate `replaceControlCharacters` to StringUtilities
e57c46f Remove `String.isDigitAt`
58d7d5b [utilities] Use Map instead of Array in TestFileSystem.Entry
609b33c Update DevTools DEPS.
3720579 Improved cookie blocked reason ui strings
2ec5e0b [COEP] Report detailed blocked reason for requests blocked by COEP
c45c1a4 Migrate Object, Progress, StringOutputStream, TextDictionary, and Throttler tests into Ninja build
b9d229c Typecheck ResourceType.js with Typescript
2a0ddd9 Typecheck SegmentedRange.js
793d1cf Locking lighthouse terms.
5c2c822 Typecheck ParsedURL.js
adf8fc3 Remove `Number.gcd`
323dfe7 [e2e] Migrates http/tests/devtools/user-metrics-perf.js to e2e
73b4421 [Issues] Add revealer for issues
3854129 Fix jsdoc for ls function
8c65a21 Typecheck common/Console.js with TypeScript
e6695b6 Reland "Typecheck Object.js"
3c56f6c Prepare ResourceMapping.js for asynchronous live locations
c7c0619 Add tests to verify sources panel shows lazy-loaded files
218e936 Remove `String#reverse` in favour of a utility function
a885e7c [e2e] Adds licences; updates expectations
6d732cc [utilities] Use Map + Set instead of Object + Array in ExtensionServer
8731cb3 Exception cannot be converted to string
07199d6 Update DevTools DEPS.
b2d65e8 Add button to clear filter in network tab
8773b01 [utilities] Remove a use-site of Array#remove in RequestCookiesView
8da0d76 [utilties] Replace use-site of Array#remove with Array#filter
193c674 Add tsc.js to inputs of ts_library
f2899ba Retry rmtree on windows
82a9d35 [deps] Roll protocol changes from v8 and chromium
d9b0620 [utilities] Use Set instead of an Array in EmulatedDevicesList
a281bd4 Move all helper functions to one folder
3844ba5 Prepare SASSSourceMapping.js for asynchronous live locations
4475248 [utilities] Use Set instead of Array for TargetModel._observers
0da1445 [utilities] Use Set instead of Array for tree outlines in SourcesPanel
cebee9c Revert "Typecheck Object.js"
1499641 Update DevTools Chromium DEPS.
d218bc3 Update DevTools DEPS.
e2abccd Remove sxg-with-network-service virtual tests from devtools-frontend
061630b Update TypeScript to 3.8.3
6b7225c Typecheck Object.js
85b5114 Reconfigure lint rule w.r.t. quotes
3524eec Remove duplicated function from helper
2f56452 Extract `collapseWhitespace` into StringUtilities
54ec60e [utilities] Use Map instead of Array for DOMNode attributes
9330d9e [utilities] Use Set instead of Array for TargetManager._targets
80b9fee Update DevTools DEPS.
e4809dc Prepare CallStackSidebarPane.js for asynchronous live locations
53421f0 Move UIString.ts tests into Ninja build
116f4df Select main thread in memory tab by default
c963762 Move String#trimURL from String prototype to a utility function
886fecc [utilities] Replace Array with Set in ResizerWidget
ef51711 [utilities] Replace Array with Set for pending animations
4d73239 Move String#isWhitespace from the String prototype to a utiltiy function
b495636 Prepare SourceFormatter.js for asynchronous live locations
0a7133b Update DevTools Chromium DEPS.
214d1ab Update DevTools DEPS.
8f4d80b Fix high contrast in Coverage panel

git-subtree-dir: resources/unpacked/devtools
git-subtree-split: ef68b16

Author: darwin

.eslintignore

@@ -3,11 +3,7 @@
 // it will ignore any that contain a glob, so if you add a
 // glob into this file it willl not mean that the
 // clang-format check also ignores that file
-
 front_end/.eslintrc.js
-front_end/InspectorBackendCommands.js
-front_end/SupportedCSSProperties.js
-front_end/accessibility/ARIAProperties.js
 front_end/cm/
 front_end/cm_headless/
 front_end/cm_modes/
@@ -18,8 +14,5 @@ front_end/protocol_externs.js
 front_end/javascript_metadata/NativeFunctions.js
 front_end/sdk/wasm_source_map/pkg/wasm_source_map.js
 front_end/third_party/
-test/e2e/resources/
-test/webtests/
-scripts/
 test/e2e/**/*.js
 test/shared/**/*.js

.eslintrc.js

@@ -28,7 +28,7 @@ module.exports = {
 
 
     // syntax preferences
-    'quotes': [2, 'single', {'avoidEscape': true, 'allowTemplateLiterals': true}],
+    'quotes': [2, 'single', {'avoidEscape': true, 'allowTemplateLiterals': false}],
     'semi': 2,
     'no-extra-semi': 2,
     'comma-style': [2, 'last'],

.gitignore

@@ -21,11 +21,6 @@ config.gypi
 karma-coverage
 npm-debug.log
 
-# These are generated for build and would be put in the symlinked folder (thus this folder)
-/front_end/InspectorBackendCommands.js
-/front_end/SupportedCSSProperties.js
-/front_end/accessibility/ARIAProperties.js
-
 /build
 /buildtools
 /out

BUILD.gn

@@ -5,6 +5,7 @@
 import("//third_party/blink/public/public_features.gni")
 
 all_devtools_files = [
+  "front_end/shell.js",
   "front_end/accessibility_test_runner/AccessibilityPaneTestRunner.js",
   "front_end/accessibility_test_runner/module.json",
   "front_end/accessibility/accessibilityNode.css",
@@ -681,6 +682,9 @@ all_devtools_modules = [
   "front_end/formatter/FormatterWorkerPool.js",
   "front_end/formatter/ScriptFormatter.js",
   "front_end/formatter/SourceFormatter.js",
+  "front_end/generated/ARIAProperties.js",
+  "front_end/generated/InspectorBackendCommands.js",
+  "front_end/generated/SupportedCSSProperties.js",
   "front_end/har_importer/har_importer.js",
   "front_end/har_importer/har_importer-legacy.js",
   "front_end/har_importer/HARFormat.js",
@@ -836,6 +840,7 @@ all_devtools_modules = [
   "front_end/platform/platform.js",
   "front_end/platform/utilities.js",
   "front_end/platform/string-utilities.js",
+  "front_end/platform/number-utilities.js",
   "front_end/profiler/profiler.js",
   "front_end/profiler/profiler-legacy.js",
   "front_end/profiler/TopDownProfileDataGrid.js",
@@ -865,6 +870,7 @@ all_devtools_modules = [
   "front_end/issues/issues.js",
   "front_end/issues/issues-legacy.js",
   "front_end/issues/IssuesPane.js",
+  "front_end/issues/IssueRevealer.js",
   "front_end/protocol/InspectorBackend.js",
   "front_end/protocol/NodeURL.js",
   "front_end/protocol/protocol.js",
@@ -897,7 +903,6 @@ all_devtools_modules = [
   "front_end/resources/ApplicationCacheItemsView.js",
   "front_end/resources/AppManifestView.js",
   "front_end/root.js",
-  "front_end/root.js",
   "front_end/Runtime.js",
   "front_end/screencast/InputModel.js",
   "front_end/screencast/screencast.js",
@@ -1344,14 +1349,6 @@ devtools_image_files = [
 
 resources_out_dir = "$root_out_dir/resources/inspector"
 
-generated_scripts = [
-  "$resources_out_dir/InspectorBackendCommands.js",
-  "$resources_out_dir/SupportedCSSProperties.js",
-]
-
-generated_aria_properties =
-    [ "$resources_out_dir/accessibility/ARIAProperties.js" ]
-
 application_templates = [
   "front_end/devtools_app.html",
   "front_end/inspector.html",
@@ -1617,6 +1614,9 @@ copied_devtools_modules = [
   "$resources_out_dir/formatter_worker/JavaScriptFormatter.js",
   "$resources_out_dir/formatter_worker/JavaScriptOutline.js",
   "$resources_out_dir/formatter_worker/RelaxedJSONParser.js",
+  "$resources_out_dir/generated/ARIAProperties.js",
+  "$resources_out_dir/generated/InspectorBackendCommands.js",
+  "$resources_out_dir/generated/SupportedCSSProperties.js",
   "$resources_out_dir/har_importer/har_importer.js",
   "$resources_out_dir/har_importer/har_importer-legacy.js",
   "$resources_out_dir/har_importer/HARFormat.js",
@@ -1772,6 +1772,7 @@ copied_devtools_modules = [
   "$resources_out_dir/platform/platform.js",
   "$resources_out_dir/platform/utilities.js",
   "$resources_out_dir/platform/string-utilities.js",
+  "$resources_out_dir/platform/number-utilities.js",
   "$resources_out_dir/profiler/profiler.js",
   "$resources_out_dir/profiler/profiler-legacy.js",
   "$resources_out_dir/profiler/TopDownProfileDataGrid.js",
@@ -1798,6 +1799,7 @@ copied_devtools_modules = [
   "$resources_out_dir/issues/issues.js",
   "$resources_out_dir/issues/issues-legacy.js",
   "$resources_out_dir/issues/IssuesPane.js",
+  "$resources_out_dir/issues/IssueRevealer.js",
   "$resources_out_dir/protocol_monitor/protocol_monitor.js",
   "$resources_out_dir/protocol_monitor/protocol_monitor-legacy.js",
   "$resources_out_dir/protocol_monitor/ProtocolMonitor.js",
@@ -2250,7 +2252,6 @@ devtools_typescript_deps = [
 ]
 
 devtools_frontend_resources_deps = devtools_typescript_deps + [
-                                     ":aria_properties",
                                      ":build_release_devtools",
                                      ":copy_devtools_modules",
                                      ":copy_embedder_scripts",
@@ -2260,16 +2261,10 @@ devtools_frontend_resources_deps = devtools_typescript_deps + [
                                      ":copy_lighthouse_locale_files",
                                      ":copy_wasm_deps",
                                      ":devtools_extension_api",
-                                     ":frontend_protocol_sources",
-                                     ":supported_css_properties",
                                    ]
 
 if (debug_devtools) {
-  devtools_frontend_resources_deps += [
-    ":build_debug_devtools",
-    ":copy_aria_properties",
-    ":copy_generated_scripts",
-  ]
+  devtools_frontend_resources_deps += [ ":build_debug_devtools" ]
 }
 
 # It is unclear why, but the Android Ninja configuration starts warning about
@@ -2320,7 +2315,9 @@ copy("copy_emulated_devices_images") {
 
 copy("copy_lighthouse_locale_files") {
   sources = lighthouse_locale_files
-  outputs = [ "$resources_out_dir/third_party/lighthouse/locales/{{source_file_part}}" ]
+  outputs = [
+    "$resources_out_dir/third_party/lighthouse/locales/{{source_file_part}}",
+  ]
 }
 
 copy("copy_wasm_deps") {
@@ -2336,8 +2333,8 @@ action("generate_devtools_grd") {
 
   grd_files =
       copied_devtools_modules + generated_applications +
-      generated_aria_properties + generated_non_autostart_non_remote_modules +
-      devtools_embedder_scripts + generated_scripts + generated_worker_bundles +
+      generated_non_autostart_non_remote_modules + devtools_embedder_scripts +
+      generated_worker_bundles +
       [
         "$resources_out_dir/devtools_extension_api.js",
         "$resources_out_dir/sdk/wasm_source_map/pkg/wasm_source_map_bg.wasm",
@@ -2377,58 +2374,15 @@ action("devtools_extension_api") {
          rebase_path(devtools_extension_api_files, root_build_dir)
 }
 
-action("supported_css_properties") {
-  script = "scripts/build/generate_supported_css.py"
-
-  inputs = [ "//third_party/blink/renderer/core/css/css_properties.json5" ]
-
-  outputs = [ "$resources_out_dir/SupportedCSSProperties.js" ]
-
-  args =
-      rebase_path(inputs, root_build_dir) + rebase_path(outputs, root_build_dir)
-}
-
-action("aria_properties") {
-  script = "scripts/build/generate_aria.py"
-
-  inputs = [ "//third_party/blink/renderer/core/html/aria_properties.json5" ]
-
-  outputs = [ "$resources_out_dir/accessibility/ARIAProperties.js" ]
-
-  args =
-      rebase_path(inputs, root_build_dir) + rebase_path(outputs, root_build_dir)
-}
-
-action("frontend_protocol_sources") {
-  script = "scripts/build/code_generator_frontend.py"
-  deps = [ "//third_party/blink/public/devtools_protocol:protocol_version" ]
-  inputs = [
-    "$root_gen_dir/third_party/blink/public/devtools_protocol/protocol.json",
-  ]
-  outputs = [ "$resources_out_dir/InspectorBackendCommands.js" ]
-
-  args = rebase_path(inputs, root_build_dir) + [
-           "--output_js_dir",
-           rebase_path(resources_out_dir, root_build_dir),
-         ]
-}
-
 action("build_release_devtools") {
   script = "scripts/build/build_release_applications.py"
 
-  deps = [
-    ":aria_properties",
-    ":frontend_protocol_sources",
-    ":supported_css_properties",
-  ]
-
   helper_scripts = [
     "scripts/build/modular_build.py",
     "scripts/build/rjsmin.py",
   ]
 
   inputs = helper_scripts + all_devtools_files + devtools_test_files +
-           generated_scripts + generated_aria_properties +
            application_templates + all_worker_entrypoints +
            # In `build_release_applications` we sometimes include
            # the content of Runtime.js into the build output.
@@ -2483,28 +2437,6 @@ if (debug_devtools) {
       rebase_path(stamp, root_build_dir),
     ]
   }
-
-  copy("copy_generated_scripts") {
-    deps = [
-      ":build_debug_devtools",
-      ":build_release_devtools",
-      ":frontend_protocol_sources",
-      ":supported_css_properties",
-    ]
-    sources = generated_scripts
-    outputs = [ "$resources_out_debug_dir/{{source_file_part}}" ]
-  }
-
-  copy("copy_aria_properties") {
-    deps = [
-      ":aria_properties",
-      ":build_debug_devtools",
-    ]
-
-    sources = generated_aria_properties
-
-    outputs = [ "$resources_out_debug_dir/accessibility/{{source_file_part}}" ]
-  }
 }
 
 group("devtools_type_check") {

DEPS

@@ -4,13 +4,13 @@
 
 vars = {
   'build_url': 'https://chromium.googlesource.com/chromium/src/build.git',
-  'build_revision': 'f0f1f409ecb5e7ce3e4e3ae5ac1f01eb5550837f',
+  'build_revision': 'e393474c8c5e0e8c7437574379709915e55b14f2',
 
   'buildtools_url': 'https://chromium.googlesource.com/chromium/src/buildtools.git',
   'buildtools_revision': 'fa6ae42dcfbf3bf965439c0bdfeb03cf4e2a5840',
 
   'depot_tools_url': 'https://chromium.googlesource.com/chromium/tools/depot_tools.git',
-  'depot_tools_revision': '9ca9c52c4c04eee136f37bab1404ae0c2319bf06',
+  'depot_tools_revision': 'ee8be8a368620af69739f41046464630ed4f2309',
 
   'inspector_protocol_url': 'https://chromium.googlesource.com/deps/inspector_protocol',
   'inspector_protocol_revision': '81ef742ba3587767fc08652d299df9e9b7051407',
@@ -23,11 +23,11 @@ vars = {
 
   # Chromium build number for unit tests. It should be regularly updated to
   # the content of https://commondatastorage.googleapis.com/chromium-browser-snapshots/Linux_x64/LAST_CHANGE
-  'chromium_linux': '745768',
+  'chromium_linux': '747553',
   # the content of https://commondatastorage.googleapis.com/chromium-browser-snapshots/Win_x64/LAST_CHANGE
-  'chromium_win': '745766',
+  'chromium_win': '747549',
   # the content of https://commondatastorage.googleapis.com/chromium-browser-snapshots/Mac/LAST_CHANGE
-  'chromium_mac': '745768',
+  'chromium_mac': '747547',
 }
 
 # Only these hosts are allowed for dependencies in this DEPS file.