S3 Without the Linter Changes #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biocross
commented
Apr 21, 2020
| @@ -33,10 +36,12 @@ const noUpdateConfiguration = { | |||
| "notes": "" | |||
| } | |||
| }; | |||
| // AWS.config.update({region: 'REGION'}); | |||
| } | ||
|
|
||
| prefs.currentURL = tunnelURL; | ||
|
|
||
| const currentIP = os.networkInterfaces().en0.find(elm => elm.family == 'IPv4').address; | ||
| const currentIP = os.networkInterfaces().en0.find(elm => elm.family === 'IPv4').address; | ||
| // const currentIP = "127.0.0.1";// os.networkInterfaces().en0.find(elm => elm.family === 'IPv4').address; |
| Bucket: bucketName, | ||
| Key: fileName, // File name you want to save as in S3 | ||
| Body: fileContent, | ||
| Acl: "public-read" |
There was a problem hiding this comment.
Should we make this ACL configurable?
| await checkForUpdate(preferences); | ||
| if (options.delete_apk.toString() === "1") { fs.unlink(pathToFile, () => { }) } |
There was a problem hiding this comment.
to remove the local build file, if the user wants.
| .alias('a') | ||
| .option('-b, --branch <branch>', 'The branch the build is from') | ||
| .option('-n, --notes <notes>', 'Release Notes for the build') | ||
| .option('-d, --delete_apk <delete_apk>', 'Release Notes for the build') |
There was a problem hiding this comment.
The argument and comment mismatch. Also, this flag seems to be platform specific (Android)
| }; | ||
|
|
||
| program | ||
| .command('submitS3 <pathToFile>') |
There was a problem hiding this comment.
How does this new command work. Is the person supposed to call librarian submit, or submitS3?
Instead of duplicating all of the submit code, we can also add a flag to existing submit code to upload to S3? Something like librarian submit --s3
| { | ||
| type: 'confirm', | ||
| name: 'enable_s3', | ||
| message: 'Do you want to enable s3 storage?', |
There was a problem hiding this comment.
Can we add some information to the README regarding this new feature?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.