Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make rag to support embedded documents workspace #90

Merged
merged 7 commits into from
Jan 13, 2024

Conversation

fengsh27
Copy link
Collaborator

@fengsh27 fengsh27 commented Jan 12, 2024

Abstract

This submission is to make rag support embedding documents workspace. Currently, all embedded documents operations such as obtaining all documents, performing similarity search and removing documents, are preformed across all embedded documents in vector store. With this submission, an embedded documents workspace (essentially a list of embedded document IDs) will be passed to rag, which is used to define the scope for all operations. If no workspace (i.e., None) passed in, all operations will be considered to be performed across all documents as before.

Besides introducing embedded documents workspace, this submission also moved xinference importing back to XinferenceDocumentEmbedder constructor. Previously, the xinference importing was moved to the beginning of the file to facilitate unit tests. However, this unexpectedly increased the size of biochatter-server docker image, even if xinference was not yet needed. By moving it back, it optimizes biochatter-server docker size and ensures that xinference is only imported when necessary.

Copy link
Contributor

@slobentanzer slobentanzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and makes sense, thanks! Will bump version to 0.3.11 after the merge.

@slobentanzer slobentanzer merged commit 5a4a26d into biocypher:main Jan 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants