Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge to master: Sync with release 3.0.3 of AgroPortal #36

Merged
merged 11 commits into from
Feb 2, 2025

Conversation

syphax-bouazzouni
Copy link

Changes

Bugs resolved

  • Fix visits page showing an empty table (80fc27d)
  • Fix self portal tooltip not working in the home page (595ecb9)
  • Fix browse categories issue when a portal is down + portals status cache expires in 10 minutes (b5989b0)
  • Fix wrong logic in categories association with parents for upload/edit forms (db5694a)
  • Fix the choice of the canonical portal, to be using the list of the request portals instead of all portals (2f40a39)
  • Fix missing loading animation when loading multiple turbo frames in a fast way (5f2d7cc)

Features

  • Show private accessible ontologies in account and browse page (656f570)
  • Show private accessible ontologies in account and browse page (656f570)
  • Add see more items component (2d48fa4)

syphax-bouazzouni and others added 11 commits December 13, 2024 00:36
#902)

* display accessible private ontologies in user account settings

* show Accessible Ontologies section in user account page only when the list of accessible ontologies is not empty

* make show private ontologies only filter on browse page displayed for all users (not only for admins)

* show private only switch in browse page only for logged in users
…deselecting (#773)

* update categories selector in admin page to allow multiple parentCategories

* handle category multiple parents in category page

* add null safety in nest categories children function

* check children inputs of a category when we check it

* deselect children of category when we delect it in browse page

* make the click categories action works only with categories input chips in browse page

* fix check method in categories controller to select parents of a child when selected and deselect children of parent when deselected

* change the name of categories stimulus controller to parent categories selector

* associate categories with their parents in upload ontology form chips

* update the logic of associating parent categories with their children to select or deselect children with their parents

* refactor parent categories selector controller code

* move categories with children logic from stimulus controller to ruby part

* remove duplicated id_to_acronym method

---------

Co-authored-by: Syphax <[email protected]>
* fix self portal tooltip not working in the home page

* make portal_config_tooltip method in home helper null safe
…ache expires in 10 minutes (#908)

* make portals status cache expires in 10 minutes

* fix browse categories issue when a portal is down
…it forms (#906)

* add a method to convert categories with children list to categories with parents list

* pass categories with parents list to the parent categories selector stimulus controller

* fix the logic to distinguish between browse page, and upload/edit forms

* clean parents categories selector stimulus controller code to remove redendence

* add a comment to explain browse page logic and upload/edit forms logic in parent categories selector stimulus controller
…a fast way (#911)

* fix white page issue when load multiple turbo frames

* replace settimeout of 0 by requestAnimationFrame
* add list items component  to hide container items if more than max items

* use list item component in concept details component for synonyms and others

* fix show edge case where max items is equal to the items total length

* remove an cyclic include raising an exception
Copy link
Author

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍

@syphax-bouazzouni syphax-bouazzouni self-assigned this Feb 2, 2025
@syphax-bouazzouni syphax-bouazzouni added the enhancement New feature or request label Feb 2, 2025
@syphax-bouazzouni syphax-bouazzouni merged commit 2da764a into biodivportal:master Feb 2, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants