[FIX] SelectRows: Index attrs only by visible in set_data#1398
Merged
Conversation
In `set_data` we calculate the index of an attribute that is passed to `add_rows`. Since `add_rows` only consider visible attributes the index has to be calculated only on visible as well. Otherwise this caused `attr_combo.setCurrentIndex` to be set to values larger than the number of items inside it. Strangely this works but causes `attr_combo.currentText()` to returns an empty string which of course breaks indexing on domain.
Current coverage is 87.62%@@ master #1398 diff @@
==========================================
Files 75 75
Lines 7460 7466 +6
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 6536 6542 +6
Misses 924 924
Partials 0 0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
set_datawe calculate the index of an attribute that is passed toadd_rows. Sinceadd_rowsonly consider visible attributes the index has to be calculated only on visible as well.Otherwise this caused
attr_combo.setCurrentIndexto be set to values larger than the number of items inside it. Strangely this works but causesattr_combo.currentText()to returns an empty string which of course breaks indexing on domain.