Skip to content

[FIX] OWScatterPlot: Fix crash on classless data#1440

Merged
lanzagar merged 1 commit into
biolab:masterfrom
VesnaT:fix_viz_rank
Jul 12, 2016
Merged

[FIX] OWScatterPlot: Fix crash on classless data#1440
lanzagar merged 1 commit into
biolab:masterfrom
VesnaT:fix_viz_rank

Conversation

@VesnaT
Copy link
Copy Markdown
Contributor

@VesnaT VesnaT commented Jul 11, 2016

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 11, 2016

Current coverage is 87.91%

Merging #1440 into master will not change coverage

@@             master      #1440   diff @@
==========================================
  Files            77         77          
  Lines          7580       7580          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           6664       6664          
  Misses          916        916          
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by 3b83934...415d6c1

@lanzagar
Copy link
Copy Markdown
Contributor

I think at first the information message was meant for the VizRank widget. After some refactoring it is now a more lightweight QDialog and can't have warnings anymore.

But using the same message on the main ScatterPlot widget is not OK.
"Data with a class variable is required." is wrong and confusing there.

An acceptable half-solution would be to use a better message, e.g. "Automatic scoring requires data with a class variable".
Even better in my opinion is to not use the information mechanism at all, and just make the message a tooltip on the disabled button.

@VesnaT VesnaT changed the title [FIX] OWScatterPlot: Fix information message reference [FIX] OWScatterPlot: Fix crash on classless data Jul 12, 2016
@lanzagar lanzagar merged commit c9b9d53 into biolab:master Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants