[FIX] Stop advertising support for weights in LogisticRegression.#1448
Merged
Conversation
The liblinear solver does not support weights in SKL, even though the parameter is there.
Current coverage is 87.91%@@ master #1448 diff @@
==========================================
Files 77 77
Lines 7584 7582 -2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6668 6666 -2
Misses 916 916
Partials 0 0
|
Contributor
|
Since codecov is also complaining, you might want to leave a test for logreg (and the new one with linreg replacing the previous one). assertFalse(LogisticRegressionLearner().supports_weights, ...) |
Member
|
+1 for second assert, this way we will get a failing test if (when) liblinear starts accepting weights. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The liblinear solver does not support weights in SKL, even though the parameter is there. Override the property to prevent errors.