[FIX] OWPredictions: Fix crash when opening report#1884
Merged
Conversation
The widget crashed when predictor's domain differed from data domain.
Current coverage is 89.25% (diff: 100%)@@ master #1884 diff @@
==========================================
Files 86 86
Lines 9100 9100
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 8122 8122
Misses 978 978
Partials 0 0
|
VesnaT
changed the title
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 10, 2017
[FIX] OWPredictions: Fix crash when opening report (cherry picked from commit ae6e05a)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 11, 2017
[FIX] OWPredictions: Fix crash when opening report (cherry picked from commit ae6e05a)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 13, 2017
[FIX] OWPredictions: Fix crash when opening report (cherry picked from commit ae6e05a)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 18, 2017
[FIX] OWPredictions: Fix crash when opening report (cherry picked from commit ae6e05a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The widget crashes when predictor's domain differs from data domain (and trying to open report)
Description of changes
Fixes #1883
To reproduce, use Iris dataset to learn on and Titanic dataset to make predictions for.
Includes