Skip to content

[FIX] scatterplot: Fix density image#1990

Merged
astaric merged 2 commits into
biolab:masterfrom
thocevar:scatterplot-density
Feb 3, 2017
Merged

[FIX] scatterplot: Fix density image#1990
astaric merged 2 commits into
biolab:masterfrom
thocevar:scatterplot-density

Conversation

@thocevar

@thocevar thocevar commented Feb 3, 2017

Copy link
Copy Markdown
Contributor
Issue

The density image (crashes) in scatterplot doesn't display with the latest version of pyqtgraph 0.10.

Description of changes

Change the dtype of the computed numpy array of pixel values to reflect the actual range of values and prevent "automatic" scaling (crashing) by pyqtgraph.

Includes
  • Code changes
  • Tests
  • Documentation

@astaric astaric added this to the 3.3.11 milestone Feb 3, 2017
@astaric

astaric commented Feb 3, 2017

Copy link
Copy Markdown
Member

It works, thanks.

@codecov-io

codecov-io commented Feb 3, 2017

Copy link
Copy Markdown

Codecov Report

Merging #1990 into master will increase coverage by -0.03%.

@@            Coverage Diff             @@
##           master    #1990      +/-   ##
==========================================
- Coverage   89.47%   89.45%   -0.03%     
==========================================
  Files          91       91              
  Lines        9198     9198              
==========================================
- Hits         8230     8228       -2     
- Misses        968      970       +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5841f7...79cd432. Read the comment docs.

@astaric astaric self-assigned this Feb 3, 2017
@thocevar thocevar force-pushed the scatterplot-density branch from dedce22 to 79cd432 Compare February 3, 2017 11:00
@astaric astaric merged commit 8921dd8 into biolab:master Feb 3, 2017
astaric added a commit that referenced this pull request Feb 3, 2017
[FIX] scatterplot: Fix density image
(cherry picked from commit 8921dd8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants