[FIX] Heatmap: Fix crash on data with empty columns#2057
Merged
Conversation
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #2057 +/- ##
========================================
Coverage ? 70.7%
========================================
Files ? 315
Lines ? 53905
Branches ? 0
========================================
Hits ? 38114
Misses ? 15791
Partials ? 0Continue to review full report at Codecov.
|
Contributor
Author
astaric
approved these changes
Mar 3, 2017
astaric
changed the title
Invalid number of variable columns Columns in a domain and in a table do not match. https://sentry.io/biolab/orange3/issues/196744285/ If a column in a table is dropped, it is erased in a domain as well.
Contributor
|
@jerneju, as a general comment: this PR contains a fix and a test, and some code reformatting. Try keeping these changes in separate commits so they are easier to review. That is, put the reformatting into a separate commit. (My pull requests may not be, or at least haven't been in the past, the best examples to follow, though. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Invalid number of variable columns
Columns in a domain and in a table do not match.
https://sentry.io/biolab/orange3/issues/196744285/
Description of changes
If a column in a table is dropped, it is erased in a domain as well.
Includes