[ENH] Scatterplot: Implement grouping of selections#2070
Merged
Conversation
janezd
force-pushed
the
scatterplot-group-selections
branch
from
7079244 to
64177cf
Compare
Contributor
Author
|
@astaric, I defined a GUI for this. :) |
Codecov Report
@@ Coverage Diff @@
## master #2070 +/- ##
==========================================
+ Coverage 70.15% 70.21% +0.05%
==========================================
Files 315 315
Lines 54096 54209 +113
==========================================
+ Hits 37952 38061 +109
- Misses 16144 16148 +4Continue to review full report at Codecov.
|
markotoplak
reviewed
Mar 3, 2017
| table = Table( | ||
| domain, data.X, data.Y, | ||
| metas=np.hstack((data.metas, selection.reshape(len(data), 1)))) | ||
| table.attributes = data.attributes |
janezd
force-pushed
the
scatterplot-group-selections
branch
4 times, most recently
from
addcd1d to
e27ddd1
Compare
Contributor
Author
|
radon fails because of an additional case in the switch-ish I'd rather not improve a cc score of a totally unrelated method just to make radon happy. |
janezd
force-pushed
the
scatterplot-group-selections
branch
from
c1319b2 to
3705ad7
Compare
janezd
force-pushed
the
scatterplot-group-selections
branch
from
3705ad7 to
3c0efd3
Compare
janezd
force-pushed
the
scatterplot-group-selections
branch
from
3c0efd3 to
5052b08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of annotating selected data with "No" and "Yes", use G0, G1, G2 ... when data is selected is subsequent groups using Shift or Cmd/Ctrl modifier.
Connect File -> Scatter plot, and then Scatter plot to a Table and also to another Scatter plot, both through signal Data (not Selection). Now select several groups in the first scatter plot by using the Shift modifier and see the results in the other scatter plot and table.
The change does not affect the other Scatter plot's output.
We can add a check box "Group selections" to enable or disable this behaviour. However, I think this should be the default behaviour and I see little reason why the user would want to disable it.
Includes