Skip to content

[FIX] VizRankDialog: Stop computation when parent widget is deleted #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
astaric merged 1 commit into from
Mar 30, 2017
Merged

[FIX] VizRankDialog: Stop computation when parent widget is deleted #2118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Orange/widgets/visualize/utils/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ def add_vizrank(cls, widget, master, button_label, set_attr_callback):

master_close_event = master.closeEvent
master_hide_event = master.hideEvent
master_delete_event = master.onDeleteWidget

def closeEvent(event):
vizrank.close()
Expand All @@ -167,8 +168,13 @@ def hideEvent(event):
vizrank.hide()
master_hide_event(event)

def deleteEvent():
vizrank.keep_running = False
master_delete_event()

master.closeEvent = closeEvent
master.hideEvent = hideEvent
master.onDeleteWidget = deleteEvent
return vizrank, button

def reshow(self):
Expand Down