[FIX] File: no domain or empty domain -> no data#2337
Merged
Conversation
Contributor
Author
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #2337 +/- ##
==========================================
- Coverage 73.39% 73.38% -0.01%
==========================================
Files 317 317
Lines 55582 55619 +37
==========================================
+ Hits 40792 40818 +26
- Misses 14790 14801 +11 |
kernc
reviewed
Jun 2, 2017
| else: | ||
| table = self.data | ||
|
|
||
| if not hasattr(table, "domain") or hasattr(table, "domain") and \ |
Contributor
There was a problem hiding this comment.
Could you simplify to table is not None and ...? As per above branching, table can be either a Table or None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes
Includes