[FIX] Mosaic Vizrank: compute_attr_order is called every step#2484
Conversation
jerneju
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2484 +/- ##
==========================================
+ Coverage 74.56% 74.59% +0.02%
==========================================
Files 320 320
Lines 56207 56209 +2
==========================================
+ Hits 41913 41930 +17
+ Misses 14294 14279 -15 |
| Return the number of combinations, starting with a single attribute | ||
| if Mosaic is colored by class distributions, and two if by Pearson | ||
| """ | ||
| self.compute_attr_order() |
There was a problem hiding this comment.
I agree it was not very good to compute the order every time one needed the count.
But that line was there because of the next one, which sets n_attrs using attr_ordering. Removing just the first and still relying on len(self.attr_ordering) is not the best.
Can you change the next line to actually compute the number of attributes? Should be trivial using len of the domain, just be careful to (not) count the class appropriately.
Then the extra calls in tests will not be needed as well.
There was a problem hiding this comment.
Fixed. I also removed some dead code. It has not been used since changing color (class) was introduced.
|
Seems there are still some issues. |
primitive meta data now used as attributes updated test
|
There are issues with subset data, but unrelated with the changes and should be fixed in another PR. |
3 participants
Issue
compute_attr_orderis called every step. It does not need to be.Description of changes
Includes