[FIX] settings: Do not clear schema_only settings on close_context#2691
Merged
astaric merged 2 commits intoOct 23, 2017
Merged
Conversation
3057ff6 to
cbefe1b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2691 +/- ##
==========================================
+ Coverage 75.83% 75.83% +<.01%
==========================================
Files 338 338
Lines 59545 59566 +21
==========================================
+ Hits 45156 45173 +17
- Misses 14389 14393 +4 |
Contributor
What if not only scatter plot; would all widgets need a |
Contributor
Author
Presumably, yes. |
cbefe1b to
c4e8017
Compare
Contributor
Author
|
A kingdom for a saveState slot. |
Member
|
@ales-erjavec the addition of sparse support in scatter plot created conflicts with this. Can you rebase? |
* undo changes to settings from biolabgh-2301 * change selection restore in scatter plot and linear projection accordingly
4bba9ce to
8767e6e
Compare
Contributor
Author
|
Ok. |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Since gh-2301 schema_only settings are destructively cleared when used in combination with a context handler. This breaks (what I would hope to be) a valid use case
This state where bar is None would then be saved in a workflow.
This pattern is used in Textable add-on for issuing uuids to widgets
The same pattern is also used in OWBaseLearner widget for the learner_name but without a context handler.
I am not sure what the intent there was. Presumably the semantics of the selection restore in scatter plot, ... is such that it is only applied once when restored from a saved workflow.
Description of changes
Includes