[ENH] OWBoxPlot: add option to sort discrete distributions by size#3156
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3156 +/- ##
==========================================
+ Coverage 82.36% 82.63% +0.27%
==========================================
Files 336 342 +6
Lines 58289 58995 +706
==========================================
+ Hits 48011 48752 +741
+ Misses 10278 10243 -35 |
|
Looks good, but sometimes while toggling the sorting the figure is not redrawn properly. |
|
Should be fixed now (i. e. I could not reproduce the issue anymore after d9fc998). |
astaric
left a comment
There was a problem hiding this comment.
Works as expected.
I would change the test dataset to something smaller though.
|
|
||
| def test_sorting_disc_group_var(self): | ||
| """Test if subgroups are sorted by their size""" | ||
| table = Table("adult") |
There was a problem hiding this comment.
can you use adult_sample? loading adult takes 0.5s to load on my computer, while loading adult_samples is instant.
There was a problem hiding this comment.
Fixed, there really was no reason to use such a large dataset for testing this.
…ple instead of adult
|
Thanks |


Issue
Implements #3093.
Description of changes
Added option (checkbox) to allow sorting discrete distributions by their size. If checkbox is unchecked, original order is preserved.
Includes