[ENH] Data Info display data set name#3187
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3187 +/- ##
==========================================
+ Coverage 82.06% 82.13% +0.06%
==========================================
Files 351 351
Lines 61898 62168 +270
==========================================
+ Hits 50799 51061 +262
- Misses 11099 11107 +8 |
lanzagar
reviewed
Aug 6, 2018
Contributor
lanzagar
left a comment
lanzagar
left a comment
There was a problem hiding this comment.
Name should also be added to the report.
Also, I noticed this widget still uses "discrete" in several places. This should be changed to "categorical". Maybe it can be added to the same PR?
| if hasattr(data, "name"): | ||
| self.data_set_name = data.name | ||
| else: | ||
| self.data_set_name = "N/A" |
Contributor
There was a problem hiding this comment.
self.data_set_name = getattr(data, "name", "N/A")
janezd
force-pushed
the
datainfo-filename
branch
from
3512bad to
41c5f3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
No data set name displayed in the info box. This could be important when checking if the names of the data sets are set correctly.
Description of changes
Includes the box with the data set name.
Includes