[FIX] OWNeuralNetwork model pickling#3230
Merged
Merged
Conversation
markotoplak
changed the title
|
How do / when can I use this fix? |
Member
Author
|
@enjoysmath, you could checkout the branch with the fixes, and then install and run it. Perhaps an easier option is to find |
|
When will it be integrated into the main branch so I can just download zip
and install? That's what I did last time...
Sry, new to github!
I can help on this project. I have like 4 years of PyQt5 experience.
And am really good at debugging, at least once I have my env set up.
I use WingWare pro.
…On Wed, Sep 5, 2018 at 1:30 PM Marko Toplak ***@***.***> wrote:
@enjoysmath <https://github.com/enjoysmath>, you could checkout the
branch with the fixes, and then install and run it. Perhaps an easier
option is to find owneuralnetwork.py on your computer and add that 1 line
I added there in this PR (the rest are tests).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3230 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABiC92m_fjIoyVrxI7NBJirZab1ztpLXks5uYDRqgaJpZM4WaU6R>
.
|
Member
|
@markotoplak, can you rebase on to the latest master? The windows failure is unrelated to these changes, but I would like to see if the new test passes. |
markotoplak
force-pushed
the
fix-nn-pickle
branch
from
f081361 to
bd29da6
Compare
Codecov Report
@@ Coverage Diff @@
## master #3230 +/- ##
========================================
Coverage ? 82.8%
========================================
Files ? 346
Lines ? 59613
Branches ? 0
========================================
Hits ? 49364
Misses ? 10249
Partials ? 0 |
lanzagar
reviewed
Sep 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3223
Includes