Skip to content

[ENH] tSNE: Output preprocessor#3407

Merged
pavlin-policar merged 1 commit into
biolab:masterfrom
VesnaT:tsne_pp
Nov 23, 2018
Merged

[ENH] tSNE: Output preprocessor#3407
pavlin-policar merged 1 commit into
biolab:masterfrom
VesnaT:tsne_pp

Conversation

@VesnaT
Copy link
Copy Markdown
Contributor

@VesnaT VesnaT commented Nov 21, 2018

Issue

Implements third part of #3342

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 21, 2018

Codecov Report

Merging #3407 into master will decrease coverage by <.01%.
The diff coverage is 98.61%.

@@            Coverage Diff             @@
##           master    #3407      +/-   ##
==========================================
- Coverage   82.33%   82.32%   -0.01%     
==========================================
  Files         360      360              
  Lines       64045    64075      +30     
==========================================
+ Hits        52729    52751      +22     
- Misses      11316    11324       +8

@VesnaT VesnaT changed the title tSNE: Output preprocessor [ENH] tSNE: Output preprocessor Nov 21, 2018
@janezd janezd assigned janezd and pavlin-policar and unassigned janezd Nov 23, 2018
Comment thread Orange/projection/manifold.py Outdated
tsne_cols = [ContinuousVariable('t-SNE-%d' % (i + 1))
for i in range(self.tsne.n_components)]
n = self.tsne.n_components
postfixes = ['x', 'y'] if n == 2 else list(range(n))
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like list(range(n)). While it would very rarely come up, it would imply that the variables are named t-SNE-0, t-SNE-1, t-SNE-2, ... I guess it is consistent with the current behaviour of Manifold learning, which outputs C0, C1. Honestly, I think t-SNE-x and t-SNE-y should be removed in favour of t-SNE-1, t-SNE-2, and if the axes are to be labelled with x and y, this should be done on the t-SNE widget level.

@pavlin-policar pavlin-policar merged commit 66e52c5 into biolab:master Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants