[ENH] Save Data: Support saving to Excel#3453
Merged
Merged
Conversation
3 tasks
janezd
reviewed
Dec 7, 2018
| data.metas) | ||
| headers = cls.header_names(data) | ||
| workbook = xlsxwriter.Workbook(filename) | ||
| print(filename) |
Contributor
There was a problem hiding this comment.
As some would say, this is print.
janezd
reviewed
Dec 7, 2018
| self.widget.filetype = t | ||
| self.widget.update_extension() | ||
| self.assertEqual(len(self.widget.get_writer_selected().EXTENSIONS), 1) | ||
| print(self.widget.get_writer_selected()) |
Contributor
There was a problem hiding this comment.
I'd like to point out that this is a print, too. :)
ajdapretnar
force-pushed
the
save-to-excel
branch
from
9907cab to
7273ada
Compare
Codecov Report
@@ Coverage Diff @@
## master #3453 +/- ##
==========================================
+ Coverage 83.27% 83.27% +<.01%
==========================================
Files 365 365
Lines 64305 64326 +21
==========================================
+ Hits 53549 53568 +19
- Misses 10756 10758 +2 |
Codecov Report
@@ Coverage Diff @@
## master #3453 +/- ##
==========================================
- Coverage 83.3% 83.27% -0.03%
==========================================
Files 365 365
Lines 64409 64324 -85
==========================================
- Hits 53654 53566 -88
- Misses 10755 10758 +3 |
lanzagar
changed the title
Contributor
xlwt only supported the old, stable .xls format. IIUC, the proposed change now introduces inability to read files of said format. |
janezd
force-pushed
the
save-to-excel
branch
from
7273ada to
83650eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Implements #3096.
Description of changes
Continued from #3306.
Remove support for .ods, since it didn't work.
Implement simple save to Excel, support only .xslx (xlwt didn't work with .xslx).
Includes