Skip to content

[FIX] Merge data: Rename variables with duplicated names#4076

Merged
janezd merged 2 commits into
biolab:masterfrom
VesnaT:merge_data
Oct 3, 2019
Merged

[FIX] Merge data: Rename variables with duplicated names#4076
janezd merged 2 commits into
biolab:masterfrom
VesnaT:merge_data

Conversation

@VesnaT
Copy link
Copy Markdown
Contributor

@VesnaT VesnaT commented Oct 3, 2019

Issue

Fixes #4070

Description of changes
  • implement Variable.rename(name)
  • check for duplicate variable names in domain and rename if any
Includes
  • Code changes
  • Tests
  • Documentation

Copy link
Copy Markdown
Contributor

@janezd janezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I understand the comments about renaming. Renaming is bad. Copying is OK. :)

Comment thread Orange/data/variable.py Outdated
Comment thread Orange/data/variable.py Outdated
Comment thread Orange/data/variable.py Outdated
Comment thread Orange/widgets/data/owmergedata.py Outdated
Comment thread Orange/widgets/data/owmergedata.py Outdated
@VesnaT VesnaT force-pushed the merge_data branch 2 times, most recently from 37b31f3 to 53fec4d Compare October 3, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge data may output domain with duplicated names

2 participants